From 0d14f46909762b8399741799b5ca75cb3993d98b Mon Sep 17 00:00:00 2001
From: Daniel Harvey <the.real.daniel.harvey@gmail.com>
Date: Sun, 17 May 2026 23:30:05 -0400
Subject: [PATCH] Fix review findings: scrub committed password, restore
 migration namespace, document Npgsql version constraint

---
 .gitignore                                    |  1 +
 DeepDrftCli/DeepDrftCli.csproj                |  1 +
 .../Data/DeepDrftContextFactory.cs            | 11 +++++++++--
 .../DeepDrftWeb.Services.csproj               |  1 +
 .../20260518025102_Initial.Designer.cs        |  2 +-
 .../Migrations/20260518025102_Initial.cs      |  2 +-
 .../DeepDrftContextModelSnapshot.cs           |  2 +-
 DeepDrftWeb/DeepDrftWeb.csproj                |  1 +
 DeepDrftWeb/appsettings.Development.json      | 19 -------------------
 DeepDrftWeb/appsettings.json                  |  2 +-
 10 files changed, 17 insertions(+), 25 deletions(-)
 delete mode 100644 DeepDrftWeb/appsettings.Development.json

diff --git a/.gitignore b/.gitignore
index 3bb1dc7..a67d0b9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -297,6 +297,7 @@ __pycache__/
 
 # Environment Secrets
 **/environment
+**/appsettings.Development.json
 
 # local sqlite files
 **/deepdrft.db*
diff --git a/DeepDrftCli/DeepDrftCli.csproj b/DeepDrftCli/DeepDrftCli.csproj
index d3a9e31..d7dfa06 100644
--- a/DeepDrftCli/DeepDrftCli.csproj
+++ b/DeepDrftCli/DeepDrftCli.csproj
@@ -9,6 +9,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.EntityFrameworkCore" Version="10.0.4" />
+    <!-- Npgsql 10.0.1 requires Microsoft.EntityFrameworkCore >= 10.0.4; keep in sync -->
     <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.1" />
     <PackageReference Include="Microsoft.Extensions.Hosting" Version="10.0.4" />
     <PackageReference Include="Microsoft.Extensions.Configuration" Version="10.0.4" />
diff --git a/DeepDrftWeb.Services/Data/DeepDrftContextFactory.cs b/DeepDrftWeb.Services/Data/DeepDrftContextFactory.cs
index d953860..97084ab 100644
--- a/DeepDrftWeb.Services/Data/DeepDrftContextFactory.cs
+++ b/DeepDrftWeb.Services/Data/DeepDrftContextFactory.cs
@@ -7,9 +7,16 @@ public class DeepDrftContextFactory : IDesignTimeDbContextFactory<DeepDrftContex
 {
     public DeepDrftContext CreateDbContext(string[] args)
     {
+        // For 'dotnet ef' commands, set ConnectionStrings__DefaultConnection in your environment.
+        // Example: export ConnectionStrings__DefaultConnection="Host=localhost;Database=deepdrft_dev;Username=postgres;Password=yourpassword"
+        var connectionString = Environment.GetEnvironmentVariable("ConnectionStrings__DefaultConnection")
+            ?? throw new InvalidOperationException(
+                "Set ConnectionStrings__DefaultConnection environment variable to run dotnet ef commands. " +
+                "Example: Host=localhost;Database=deepdrft_dev;Username=postgres;Password=yourpassword");
+
         var optionsBuilder = new DbContextOptionsBuilder<DeepDrftContext>();
-        optionsBuilder.UseNpgsql("Host=localhost;Database=deepdrft_dev;Username=postgres;Password=postgres");
-        
+        optionsBuilder.UseNpgsql(connectionString);
+
         return new DeepDrftContext(optionsBuilder.Options);
     }
 }
\ No newline at end of file
diff --git a/DeepDrftWeb.Services/DeepDrftWeb.Services.csproj b/DeepDrftWeb.Services/DeepDrftWeb.Services.csproj
index aee9b71..26da6f1 100644
--- a/DeepDrftWeb.Services/DeepDrftWeb.Services.csproj
+++ b/DeepDrftWeb.Services/DeepDrftWeb.Services.csproj
@@ -16,6 +16,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <!-- Npgsql 10.0.1 requires Microsoft.EntityFrameworkCore >= 10.0.4; keep in sync -->
     <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.1" />
   </ItemGroup>
 
diff --git a/DeepDrftWeb.Services/Migrations/20260518025102_Initial.Designer.cs b/DeepDrftWeb.Services/Migrations/20260518025102_Initial.Designer.cs
index 5301e98..1be11d7 100644
--- a/DeepDrftWeb.Services/Migrations/20260518025102_Initial.Designer.cs
+++ b/DeepDrftWeb.Services/Migrations/20260518025102_Initial.Designer.cs
@@ -9,7 +9,7 @@ using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
 
 #nullable disable
 
-namespace DeepDrftWeb.Services.Migrations
+namespace DeepDrftWeb.Migrations
 {
     [DbContext(typeof(DeepDrftContext))]
     [Migration("20260518025102_Initial")]
diff --git a/DeepDrftWeb.Services/Migrations/20260518025102_Initial.cs b/DeepDrftWeb.Services/Migrations/20260518025102_Initial.cs
index 6735fda..2662487 100644
--- a/DeepDrftWeb.Services/Migrations/20260518025102_Initial.cs
+++ b/DeepDrftWeb.Services/Migrations/20260518025102_Initial.cs
@@ -4,7 +4,7 @@ using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
 
 #nullable disable
 
-namespace DeepDrftWeb.Services.Migrations
+namespace DeepDrftWeb.Migrations
 {
     /// <inheritdoc />
     public partial class Initial : Migration
diff --git a/DeepDrftWeb.Services/Migrations/DeepDrftContextModelSnapshot.cs b/DeepDrftWeb.Services/Migrations/DeepDrftContextModelSnapshot.cs
index ca1c25b..e795600 100644
--- a/DeepDrftWeb.Services/Migrations/DeepDrftContextModelSnapshot.cs
+++ b/DeepDrftWeb.Services/Migrations/DeepDrftContextModelSnapshot.cs
@@ -8,7 +8,7 @@ using Npgsql.EntityFrameworkCore.PostgreSQL.Metadata;
 
 #nullable disable
 
-namespace DeepDrftWeb.Services.Migrations
+namespace DeepDrftWeb.Migrations
 {
     [DbContext(typeof(DeepDrftContext))]
     partial class DeepDrftContextModelSnapshot : ModelSnapshot
diff --git a/DeepDrftWeb/DeepDrftWeb.csproj b/DeepDrftWeb/DeepDrftWeb.csproj
index e9fa3c2..f50f99b 100644
--- a/DeepDrftWeb/DeepDrftWeb.csproj
+++ b/DeepDrftWeb/DeepDrftWeb.csproj
@@ -18,6 +18,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
+    <!-- Npgsql 10.0.1 requires Microsoft.EntityFrameworkCore >= 10.0.4; keep in sync -->
     <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.1" />
     <ProjectReference Include="..\DeepDrftModels\DeepDrftModels.csproj" />
     <ProjectReference Include="..\DeepDrftWeb.Client\DeepDrftWeb.Client.csproj" />
diff --git a/DeepDrftWeb/appsettings.Development.json b/DeepDrftWeb/appsettings.Development.json
deleted file mode 100644
index 88066b5..0000000
--- a/DeepDrftWeb/appsettings.Development.json
+++ /dev/null
@@ -1,19 +0,0 @@
-{
-  "Logging": {
-    "LogLevel": {
-      "Default": "Information",
-      "Microsoft.AspNetCore": "Warning",
-      "DeepDrftWeb.Client.Services.StreamingAudioPlayerService": "Debug"
-    },
-    "Console": {
-      "FormatterName": "simple",
-      "LogLevel": {
-        "Default": "Information"
-      }
-    }
-  },
-  "DetailedErrors": true,
-  "ApiUrls": {
-    "ContentApi": "http://localhost:54494/"
-  }
-}
diff --git a/DeepDrftWeb/appsettings.json b/DeepDrftWeb/appsettings.json
index 7262041..7b8bb3f 100644
--- a/DeepDrftWeb/appsettings.json
+++ b/DeepDrftWeb/appsettings.json
@@ -7,7 +7,7 @@
   },
   "AllowedHosts": "*",
   "ConnectionStrings": {
-    "DefaultConnection": "Host=localhost;Database=deepdrft_dev;Username=postgres;Password=postgres"
+    "DefaultConnection": "Host=localhost;Database=deepdrft_dev;Username=postgres;Password=REPLACE_IN_ENV"
   },
   "ApiUrls": {
     "ContentApi": "http://localhost:12777/"