Fix Critical: IndexSystem lock races and TrackRepository.Update silent-create

- Replace object lock with SemaphoreSlim(1,1) on both DirectoryIndexDirectory
  and VaultIndexDirectory; SaveIndexAsync now executes inside the semaphore
  so mutate+persist is atomic
- ReloadIndexAsync acquires the semaphore before LoadIndexAsync so disk load
  and in-memory swap are atomic with respect to concurrent writes
- HasIndexEntry and GetEntryMetadata converted to async Task with WaitAsync;
  MediaVault.GetEntryAsync call sites updated accordingly
- TrackRepository.Update throws InvalidOperationException when Id not found
  instead of silently calling Create; service layer catches and wraps as fail result
This commit is contained in:
Daniel Harvey
2026-05-17 11:24:50 -04:00
parent 56d15027e4
commit 4a0c17c318
6 changed files with 57 additions and 31 deletions
+4 -4
View File
@@ -492,13 +492,13 @@ public class IndexSystemTests
await database!.CreateVaultAsync(testVaultKey, MediaVaultType.Image);
// Assert
Assert.That(database.HasIndexEntry(testVaultKey), Is.True, "Should contain added entry");
Assert.That(await database.HasIndexEntry(testVaultKey), Is.True, "Should contain added entry");
Assert.That(database.GetIndexSize(), Is.EqualTo(1), "Should have one entry");
Assert.That(File.Exists(IndexPath), Is.True, "Should persist to file");
// Verify persistence by reloading database
var reloadedDatabase = await FileDatabase.FromAsync(TestDirectory);
Assert.That(reloadedDatabase!.HasIndexEntry(testVaultKey), Is.True, "Should persist entry across restarts");
Assert.That(await reloadedDatabase!.HasIndexEntry(testVaultKey), Is.True, "Should persist entry across restarts");
}
[Test]
@@ -516,13 +516,13 @@ public class IndexSystemTests
await vault!.AddEntryAsync(testKey, testImage);
// Assert
Assert.That(vault.HasIndexEntry(testKey), Is.True, "Should contain added entry");
Assert.That(await vault.HasIndexEntry(testKey), Is.True, "Should contain added entry");
Assert.That(vault.GetIndexSize(), Is.EqualTo(1), "Should have one entry");
Assert.That(File.Exists(IndexPath), Is.True, "Should persist to file");
// Verify persistence by reloading vault
var reloadedVault = await ImageVault.FromAsync(TestDirectory);
Assert.That(reloadedVault!.HasIndexEntry(testKey), Is.True, "Should persist entry across restarts");
Assert.That(await reloadedVault!.HasIndexEntry(testKey), Is.True, "Should persist entry across restarts");
}
}
}