daniel/deepdrft
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 13 Wiki Activity

Fix Critical: IndexSystem lock races and TrackRepository.Update silent-create

Browse Source 
- Replace object lock with SemaphoreSlim(1,1) on both DirectoryIndexDirectory
  and VaultIndexDirectory; SaveIndexAsync now executes inside the semaphore
  so mutate+persist is atomic
- ReloadIndexAsync acquires the semaphore before LoadIndexAsync so disk load
  and in-memory swap are atomic with respect to concurrent writes
- HasIndexEntry and GetEntryMetadata converted to async Task with WaitAsync;
  MediaVault.GetEntryAsync call sites updated accordingly
- TrackRepository.Update throws InvalidOperationException when Id not found
  instead of silently calling Create; service layer catches and wraps as fail result
This commit is contained in:
Daniel Harvey
2026-05-17 11:24:50 -04:00
parent 56d15027e4
commit 4a0c17c318
6 changed files with 57 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files
DeepDrftTests/MediaVaultTests.cs
+5 -5
View File
@@ -120,7 +120,7 @@ public class MediaVaultTests
await _imageVault.AddEntryAsync(entryKey, imageBinary);
// Assert
Assert.That(_imageVault.HasIndexEntry(entryKey), Is.True, "Should add to index");
Assert.That(await _imageVault.HasIndexEntry(entryKey), Is.True, "Should add to index");
var expectedFilePath = Path.Combine(TestDirectory, "test-image.png");
AssertMediaFileExists(expectedFilePath, imageBinary.Buffer);
@@ -148,7 +148,7 @@ public class MediaVaultTests
foreach (var (key, binary) in entries)
{
Assert.That(_imageVault.HasIndexEntry(key), Is.True, $"Should contain {key} in index");
Assert.That(await _imageVault.HasIndexEntry(key), Is.True, $"Should contain {key} in index");
var expectedFilePath = Path.Combine(TestDirectory, $"{key}.png");
AssertMediaFileExists(expectedFilePath, binary.Buffer);
}
@@ -264,7 +264,7 @@ public class MediaVaultTests
await _audioVault.AddEntryAsync(entryKey, audioBinary);
// Assert
Assert.That(_audioVault.HasIndexEntry(entryKey), Is.True, "Should add to index");
Assert.That(await _audioVault.HasIndexEntry(entryKey), Is.True, "Should add to index");
var expectedFilePath = Path.Combine(TestDirectory, "test-audio.mp3");
AssertMediaFileExists(expectedFilePath, audioBinary.Buffer);
@@ -337,7 +337,7 @@ public class MediaVaultTests
return (string)method!.Invoke(_vault, new object[] { mediaKey })!;
}
public bool HasIndexEntry(string entryId) => _vault.HasIndexEntry(entryId);
public Task<bool> HasIndexEntry(string entryId) => _vault.HasIndexEntry(entryId);
public Task AddEntryAsync(string entryId, FileBinary media) =>
_vault.AddEntryAsync(entryId, media);
}
@@ -423,7 +423,7 @@ public class MediaVaultTests
await vault!.AddEntryAsync(entryKey, imageBinary);
// Assert
Assert.That(vault.HasIndexEntry(entryKey), Is.True, "Should add entry to index");
Assert.That(await vault.HasIndexEntry(entryKey), Is.True, "Should add entry to index");
var expectedFilePath = Path.Combine(TestDirectory, "test-media.png");
AssertMediaFileExists(expectedFilePath, imageBinary.Buffer);