fix: Wave 18.1 review — pre-skip subtraction, t=0 anchor, PreSkip in sidecar, stderr on cancel

2026-06-23 06:55:31 -04:00
parent 33d6f34d8a
commit 6add30a4ff
6 changed files with 251 additions and 45 deletions
@@ -90,11 +90,13 @@ public sealed class FfmpegOpusEncoder
        catch (OperationCanceledException) when (ct.IsCancellationRequested)
        {
            TryKill(process);
+            await SafeStderr(stderrTask); // observe to avoid unobserved-task warnings
            throw; // genuine shutdown cancellation — let it propagate
        }
        catch (OperationCanceledException)
        {
            TryKill(process);
+            await SafeStderr(stderrTask); // observe to avoid unobserved-task warnings
            _logger.LogError("Opus transcode: ffmpeg exceeded the {Timeout}s timeout for {Source}.",
                _options.TimeoutSeconds, sourcePath);
            return false;