daniel/deepdrft
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 13 Wiki Activity

fix(manager): review remediation — DeleteTrackAsync dead code, TrackEdit Id long, dead @using

Browse Source
This commit is contained in:
Daniel Harvey
2026-05-24 21:14:26 -04:00
parent 428359b241
commit 7f99479cae
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
DeepDrftManager/Services/CmsTrackService.cs
+5 -4
View File
@@ -142,17 +142,18 @@ public class CmsTrackService : ICmsTrackService
var lookup = await _trackService.GetById(id);
if (!lookup.Success)
{
var error = lookup.Messages.FirstOrDefault()?.Message;
_logger.LogError("CMS delete: lookup failed for track {TrackId}: {Error}", id, error);
var error = lookup.Messages.FirstOrDefault()?.Message ?? "unknown error";
_logger.LogError("CMS delete: GetById threw for track {TrackId}: {Error}", id, error);
return Result.CreateFailResult("Failed to load track.");
}
var track = lookup.Value;
if (track is null)
if (lookup.Value is null)
{
return Result.CreateFailResult("Track not found.");
}
var track = lookup.Value;
var entryKey = track.EntryKey;
// 2. SQL delete. On failure, do NOT touch the vault — nothing to clean up.