daniel/deepdrft
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 13 Wiki Activity

fix(mp3): guard sub-frame tail in getAlignedSegmentSize to prevent over-read past availableBytes

Browse Source
This commit is contained in:
daniel-c-harvey
2026-06-11 09:04:53 -04:00
parent b04081b960
commit a2771c71aa
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
DeepDrftPublic/Interop/audio/Mp3FormatDecoder.ts
+4
View File
@@ -79,10 +79,14 @@ export class Mp3FormatDecoder implements IFormatDecoder {
if (info.blockAlign > 0) { if (info.blockAlign > 0) {
// CBR: align to complete MP3 frames so each segment is independently decodable. // CBR: align to complete MP3 frames so each segment is independently decodable.
// Guard: need at least one full frame; discard sub-frame tail rather than over-reading.
if (availableBytes < info.blockAlign) return 0;
const minFrames = Math.ceil(minSize / info.blockAlign); const minFrames = Math.ceil(minSize / info.blockAlign);
const availableFrames = Math.floor(availableBytes / info.blockAlign); const availableFrames = Math.floor(availableBytes / info.blockAlign);
if (!streamComplete && availableFrames < minFrames) return 0; if (!streamComplete && availableFrames < minFrames) return 0;
const requestedFrames = Math.floor(Math.min(requestedSize, availableBytes) / info.blockAlign); const requestedFrames = Math.floor(Math.min(requestedSize, availableBytes) / info.blockAlign);
// Never exceed availableBytes (clamp via requestedFrames which is floor'd from availableBytes).
return Math.max(streamComplete ? 1 : minFrames, requestedFrames) * info.blockAlign; return Math.max(streamComplete ? 1 : minFrames, requestedFrames) * info.blockAlign;
} }