Q-W0 code-review remediation: pitch_shift follower self-heal, T3-03 rate bail, doc/comment riders

2026-07-28 19:27:12 -04:00
parent 15d293b42f
commit 16b2a1b8ca
5 changed files with 79 additions and 14 deletions
@@ -315,6 +315,14 @@ the clean bills) are deliberately absent.
  fallback): document-and-defer with the comment amended to name the 44.1 k assumption, if zero
  UI-feel change is preferred. (Folding either into Q-W2v instead is *not* recommended — it
  would put behavior changes inside a mechanical-split wave; §2.5(8).)
+
+  **Recorded deviation (Q-W0 remediation, code review):** T3-03 as implemented resolves
+  `fadeMaxFrames()` against `liveSampleRate()` (the host/project rate), not the per-file rate
+  this section's text literally suggests ("the loaded source's rate"). Reviewer verified this
+  is the more correct choice: no resample path exists anywhere in `src/`, the engine advances
+  one source frame per host frame, and this matches the time base `paintEnvelopeOverlay`
+  already uses for the same fades (`totalSeconds = frames / liveSampleRate()`). No further
+  action — recorded here so the audit text and the shipped behavior don't read as diverged.
 - **(e) WAV/RIFF consolidation moment — the one true track disagreement (T2-08 vs T4-23/T4-10).**
  T2 prefers the `core/wav` homing moment (the relocation wave); T4 prefers "the wave that opens
  `ingest.cpp`" — which does not exist, and T4-10 points back circularly. *Recommend:* record