Bake window derives itself: %-knob fold, declick pad, Gate held to exhaustion, preview velocity; Hold is the one knob a loop needs

src/shell/instrument/editor_controls.cpp

@@ -15,6 +15,7 @@
 
 #include "core/instrument/engine/filter/filter_params.h"  // the filter's own control laws
 #include "core/instrument/engine/master_gain.h"  // master-gain dB<->linear<->knob taper
+#include "core/instrument/ui/bake_hold.h"        // the Hold knob's ladder map
 #include "core/instrument/ui/deck_groups.h"      // sampleDeckGroups (the deck's composition)
 #include "core/instrument/ui/deck_values.h"      // the parameter-set binding + its ms units
 #include "core/instrument/ui/knob_deck.h"        // deckHeight / kDeckKnobSize (the band's own height)
@@ -112,8 +113,13 @@ double ReaSamplerEditor::previewVelocity01() const {
     return static_cast<double>(processor_->previewVelocity()) / 127.0;
 }
 
+double ReaSamplerEditor::bakeHoldNorm() const {
+    return instrument::ui::bakeHoldNorm(params_.bakeHold);
+}
+
 double ReaSamplerEditor::deckControlNorm(int id) const {
     if (id == -2) return previewVelocity01();  // the chrome preview-velocity knob
+    if (id == kBakeHoldKnobId) return bakeHoldNorm();
     switch (static_cast<ParamControl>(id)) {
         case ParamControl::kKeyTrack:
             return clamp01(params_.keyTrack / kKeyTrackMax);
@@ -145,6 +151,11 @@ void ReaSamplerEditor::applyDeckKnob(int id, double norm) {
         processor_->setPreviewVelocity(static_cast<std::uint8_t>(norm * 127.0 + 0.5));
         return;
     }
+    if (id == kBakeHoldKnobId) {
+        // A parameter-set edit like the deck's own knobs: the commit lands on release.
+        params_.bakeHold = instrument::ui::bakeHoldFromNorm(norm);
+        return;
+    }
     switch (static_cast<ParamControl>(id)) {
         case ParamControl::kVoiceCount: {
             // Stepped: quantize the continuous drag to the integer count and track it live
@@ -171,7 +182,7 @@ std::string ReaSamplerEditor::deckValueLabel(int id) const {
     char buf[24];
     buf[0] = '\0';
     const PlaySeconds& play = params_.play;
-    switch (id == -2 ? ParamControl::kCount : static_cast<ParamControl>(id)) {
+    switch (id < 0 ? ParamControl::kCount : static_cast<ParamControl>(id)) {
         case ParamControl::kAttack:
             formatEnvTimeMs(play.adsr.attackSeconds, buf, sizeof(buf)); break;
         case ParamControl::kHold:
@@ -263,7 +274,8 @@ std::string ReaSamplerEditor::deckValueLabel(int id) const {
             snprintf(buf, sizeof(buf), "^%.2f", curveExponentFor(id, play));
             break;
         default:
-            // -2 (preview velocity) is labeled at its chrome call site; nothing else here.
+            // The chrome knobs (preview velocity, bake Hold) are labeled at their own call
+            // site; nothing else here.
             break;
     }
     return std::string(buf);