Loop-crossfade-ux review fixes: parked-drag no longer fakes LOOP OFF, waveform label contrast fixed, hover memoizes its bank read
Also corrects the cap-area, em-dash, glyph-overhang and heuristic-comment findings noted in review.
This commit is contained in:
@@ -45,8 +45,16 @@ LoopWrite applyLoopMarks(const LoopMarks& m) {
|
||||
LoopWrite w;
|
||||
const bool spanAlive = m.loopEnd > m.loopStart;
|
||||
w.loop.hasLoop = m.hasLoop && spanAlive;
|
||||
w.loop.start = m.loopStart;
|
||||
w.loop.end = m.loopEnd;
|
||||
if (m.parked && !m.hasLoop) {
|
||||
// A parked pair (never set) must round-trip back to parked, not to a real "LOOP OFF"
|
||||
// span — resolveLoopMarks only re-parks a span spanUsable would refuse, so collapse it
|
||||
// deliberately rather than writing back the default bounds' own alive span.
|
||||
w.loop.start = m.loopStart;
|
||||
w.loop.end = m.loopStart;
|
||||
} else {
|
||||
w.loop.start = m.loopStart;
|
||||
w.loop.end = m.loopEnd;
|
||||
}
|
||||
w.crossfade = (spanAlive && m.crossfade > 0) ? m.crossfade : 0;
|
||||
w.start = m.start;
|
||||
return w;
|
||||
|
||||
Reference in New Issue
Block a user