Loop-crossfade-ux review fixes: parked-drag no longer fakes LOOP OFF, waveform label contrast fixed, hover memoizes its bank read

Also corrects the cap-area, em-dash, glyph-overhang and heuristic-comment findings noted in review.
This commit is contained in:
2026-08-02 05:50:38 -04:00
parent a7c3c7a828
commit 1b4d0e67b7
10 changed files with 125 additions and 27 deletions
+3 -2
View File
@@ -157,8 +157,9 @@ static void testHoldCellIsReservedAndFollowsTheVelocityCellGrammar() {
// the agreed remedy if it cannot is to narrow the enable's segments, never to move the floor.
static void testTheControlRunLeavesTheTitleReadableAtTheEditorFloor() {
const ChromeRects r = chromeRects(chromeBand(), kKnob);
// "ReaSampler 9000" (15 chars) plus a bracketed 20-char capture name, at the toolbar font's
// generous ~7 px/char estimate: 38 * 7.
// "ReaSampler 9000" (15 chars) plus a bracketed 20-char capture name, at an assumed 7 px/char
// for the toolbar font: 38 * 7. A HEURISTIC, not a measured Segoe UI metric — no font-metric
// measurement backs this number; it gates a phase-wide acceptance criterion regardless.
constexpr int kTitleTextFloorPx = 266;
CHECK(r.title.width >= kTitleTextFloorPx);
// Nothing in the run reaches into the title's slot.