daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: point the three bumpBankGeneration citations at the right line

Browse Source 
A prior pass corrected session.h:108 to :114, but :114 is the read accessor;
the bump is at :121. Also corrects a module count in the package doc.
This commit is contained in:
Daniel Harvey
2026-08-02 14:23:03 -04:00
parent f9b191bd36
commit 2069ae8086
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/PLAN.md
+2 -2
View File
@@ -2366,7 +2366,7 @@ These bind every track in this phase, in addition to the plan-wide set above.
touching it must **cite, not restate**. touching it must **cite, not restate**.
- **Export is read-only against the project.** No ext-state write, no `bumpBankGeneration()`, - **Export is read-only against the project.** No ext-state write, no `bumpBankGeneration()`,
no undo point. Import does the opposite: it bumps the generation no undo point. Import does the opposite: it bumps the generation
(`src/shell/persist/session.h:114`) so live ReaSampler 9000 instances reload, and batches (`src/shell/persist/session.h:121`) so live ReaSampler 9000 instances reload, and batches
its index mutation into one Ctrl-Z through `persistBankOp`. its index mutation into one Ctrl-Z through `persistBankOp`.
- **All-or-nothing on both sides.** No partial export, no partial import. A truncated - **All-or-nothing on both sides.** No partial export, no partial import. A truncated
`.rsbank` must never exist on disk (temp file + atomic rename, the Ψ-W2-T2 precedent); a `.rsbank` must never exist on disk (temp file + atomic rename, the Ψ-W2-T2 precedent); a
@@ -2792,7 +2792,7 @@ fold, it does not add a second one), `origin_ledger` (Ε-W1-T3's).
remain as orphans until a prune reclaims them — the same designed window a non-empty bank remain as orphans until a prune reclaims them — the same designed window a non-empty bank
delete already produces (`core/model/CLAUDE.md`'s sample-removal section). The user-facing delete already produces (`core/model/CLAUDE.md`'s sample-removal section). The user-facing
summary says so. summary says so.
- **`bumpBankGeneration()` on success** (`session.h:114`), so live instances reload. - **`bumpBankGeneration()` on success** (`session.h:121`), so live instances reload.
- **No timeline item is placed. Ever.** - **No timeline item is placed. Ever.**
- **A new FOREVER-STABLE command id**, minted the same way T1's is. - **A new FOREVER-STABLE command id**, minted the same way T1's is.
docs/product/bank-package.md
+1 -1
View File
@@ -690,7 +690,7 @@ constructors.
freshly-generated pair. freshly-generated pair.
- **Bank generation.** Import mutates bank content that live ReaSampler 9000 - **Bank generation.** Import mutates bank content that live ReaSampler 9000
instances may play, so it must `bumpBankGeneration()` instances may play, so it must `bumpBankGeneration()`
(`src/shell/persist/session.h:114`, whose own comment says call sites "err toward (`src/shell/persist/session.h:121`, whose own comment says call sites "err toward
bumping"). Export mutates nothing and must bump nothing, write no ext state, and bumping"). Export mutates nothing and must bump nothing, write no ext state, and
open no undo point. open no undo point.
- **Beta/stable channel isolation.** Packages are channel-**agnostic** and this is - **Beta/stable channel isolation.** Packages are channel-**agnostic** and this is
src/core/package/CLAUDE.md
+1 -1
View File
@@ -87,7 +87,7 @@ both have landed.
`ledgerRefusalMessage` (the gate's console-block body, a pure `ledgerRefusalMessage` (the gate's console-block body, a pure
`(LedgerRefusal, namespace) -> string` fold the shell only supplies the `(LedgerRefusal, namespace) -> string` fold the shell only supplies the
channel-correct namespace to). channel-correct namespace to).
- `bank_package` — framing and arithmetic composing the two above: - `bank_package` — framing and arithmetic composing the four above:
`encodePackage` (prefix bytes + layout + total size, stamping this build's `encodePackage` (prefix bytes + layout + total size, stamping this build's
ladder pair and `version::stampVersion()`), `decodePackage` (prefix + observed ladder pair and `version::stampVersion()`), `decodePackage` (prefix + observed
file size in; header/manifest/layout out), and `requiredPrefixSize` (the file size in; header/manifest/layout out), and `requiredPrefixSize` (the