daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

Browse Source
This commit is contained in:
Daniel Harvey
2026-07-28 21:33:51 -04:00
parent 847936f813
commit 2d59bbe35d
131 changed files with 460 additions and 263 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CMakeLists.txt
+17 -2
View File
@@ -249,6 +249,16 @@ target_include_directories(tail_control PUBLIC src)
target_link_libraries(tail_control PUBLIC render_settings)
target_link_libraries(tail_control PRIVATE json)
# ---------------------------------------------------------------------------
# 2g''') Pure slot_map library — NO REAPER, NO SWELL. The L7 gap-preserving
# display-position carrier for one bank (extracted from bank_book, Q-W1
# T4-05): sample id -> slot, gap-preserving append/remove/reorder/reconcile,
# JSON round-trip. Mirror of bank_model; wrapped (not merged) by bank_book.
# ---------------------------------------------------------------------------
add_library(slot_map STATIC src/core/model/slot_map.cpp)
target_include_directories(slot_map PUBLIC src)
target_link_libraries(slot_map PRIVATE json)
# ---------------------------------------------------------------------------
# 2g') Pure bank_book library — NO REAPER, NO SWELL. The multi-bank phase heart
# (Phase B1): an ordered registry of banks (pool seeded as bank-zero + named
@@ -257,9 +267,10 @@ target_link_libraries(tail_control PRIVATE json)
# sample between banks, JSON round-trip + legacy-bank_index→pool migration.
# Mirror of bank_model / view_mode_model; wraps BankIndex (bank_model untouched).
# ---------------------------------------------------------------------------
add_library(bank_book STATIC src/core/model/bank_book.cpp src/core/model/slot_map.cpp)
add_library(bank_book STATIC src/core/model/bank_book.cpp)
target_include_directories(bank_book PUBLIC src)
target_link_libraries(bank_book PUBLIC bank_model)
target_link_libraries(bank_book PUBLIC slot_map)
target_link_libraries(bank_book PRIVATE json)
# ---------------------------------------------------------------------------
@@ -404,7 +415,7 @@ target_include_directories(drag_out PUBLIC src)
# parallel byte writer — so the cross-artifact contract cannot drift; links
# sample_map (which pulls bank_book/wav_trim/sampler_core transitively) and
# NEITHER SDK. The class-ID string derives from the FROZEN UID macros
# (src/shell/instrument/reasampler_uid.h, SDK-free), channel-selected via the generated
# (src/core/wire/reasampler_uid.h, SDK-free), channel-selected via the generated
# version header — hence the generated include dir. The round-trip test parses
# the container and decodes back through the instrument's own reader. Mirror of
# assignment_request.
@@ -645,6 +656,10 @@ add_executable(bank_book_tests tests/test_bank_book.cpp)
target_link_libraries(bank_book_tests PRIVATE bank_book)
add_test(NAME bank_book_tests COMMAND bank_book_tests)
add_executable(slot_map_tests tests/test_slot_map.cpp)
target_link_libraries(slot_map_tests PRIVATE slot_map json)
add_test(NAME slot_map_tests COMMAND slot_map_tests)
add_executable(wav_trim_tests tests/test_wav_trim.cpp)
target_link_libraries(wav_trim_tests PRIVATE wav_trim)
add_test(NAME wav_trim_tests COMMAND wav_trim_tests)