Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

This commit is contained in:
2026-07-28 21:33:51 -04:00
parent 847936f813
commit 2d59bbe35d
131 changed files with 460 additions and 263 deletions
+1 -1
View File
@@ -48,4 +48,4 @@ void formatMasterGainLabel(double norm, char* buf, std::size_t len) {
std::snprintf(buf, len, "%+.1fdB", db);
}
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
+1 -1
View File
@@ -55,4 +55,4 @@ double masterGainNormFromLinear(double linear);
// including the terminator. Pure.
void formatMasterGainLabel(double norm, char* buf, std::size_t len);
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
+1 -1
View File
@@ -431,4 +431,4 @@ AudioSample PitchShifter::processImpl(AudioSample in, const SpliceEvent* linked)
return static_cast<AudioSample>(out);
}
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
+1 -1
View File
@@ -227,4 +227,4 @@ private:
// live fade by that rate.
};
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
@@ -269,4 +269,4 @@ bool VelocityCurve::equals(const VelocityCurve& other, double eps) const {
return true;
}
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
+1 -1
View File
@@ -168,4 +168,4 @@ private:
std::vector<VelocityPoint> points_;
};
} // namespace reasampler::instrument::engine
} // namespace reasampler::instrument::engine
+1 -1
View File
@@ -60,4 +60,4 @@ AssignConsumeDecision consumeDecision(const std::optional<AssignmentRequest>& re
return d;
}
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -104,4 +104,4 @@ AssignConsumeDecision consumeDecision(const std::optional<AssignmentRequest>& re
std::int64_t lastConsumed, bool resolves,
bool isFocusedTarget);
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -13,4 +13,4 @@ std::optional<std::string> decodeGetProjExtState(int apiReturn,
return buffer;
}
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -34,4 +34,4 @@ namespace reasampler::instrument::map {
std::optional<std::string> decodeGetProjExtState(int apiReturn,
const std::string& buffer);
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -110,4 +110,4 @@ std::optional<int> parseNoteEntry(const std::string& text) {
return parseNoteName(s);
}
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -30,4 +30,4 @@ namespace reasampler::instrument::map {
// into [0,127]; empty or unparseable input returns nullopt (no change). Pure — no host types.
std::optional<int> parseNoteEntry(const std::string& text);
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -24,4 +24,4 @@ std::int64_t fadeFractionToFrames(double fadeFraction, std::int64_t playLength)
return static_cast<std::int64_t>(fadeFraction * static_cast<double>(playLength) + 0.5);
}
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -48,4 +48,4 @@ double framesToFadeFraction(std::int64_t fadeFrames, std::int64_t playLength);
// Rounds to nearest integer frame. Returns 0 when playLength == 0.
std::int64_t fadeFractionToFrames(double fadeFraction, std::int64_t playLength);
} // namespace reasampler::instrument::map
} // namespace reasampler::instrument::map
+1 -1
View File
@@ -155,4 +155,4 @@ std::vector<int> filterNameIndices(const std::vector<std::string>& names,
return out;
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -104,4 +104,4 @@ bool nameMatchesQuery(const std::string& name, const std::string& query);
std::vector<int> filterNameIndices(const std::vector<std::string>& names,
const std::string& query);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -93,4 +93,4 @@ int filterTabHitTest(const BrowserLayout& layout, int tabCount, int x, int y) {
return -1;
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -89,4 +89,4 @@ Rect filterTabRect(const BrowserLayout& layout, int tabCount, int index);
// tab strip. Pure.
int filterTabHitTest(const BrowserLayout& layout, int tabCount, int x, int y);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -38,4 +38,4 @@ bool popupOutsideSheet(const CurvePopupLayout& layout, int x, int y) {
return !contains(layout.sheet, x, y);
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -45,4 +45,4 @@ CurvePopupLayout computeCurvePopup(int w, int h);
// The shell additionally gates on "no drag in flight" (spec). Pure.
bool popupOutsideSheet(const CurvePopupLayout& layout, int x, int y);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -159,4 +159,4 @@ bool addZoneHitTest(const KeymapEditorLayout& layout, int x, int y) {
return contains(layout.addZoneButton, x, y);
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -139,4 +139,4 @@ ZoneHit zoneHitTest(const KeymapEditorLayout& layout, int zoneCount, int x, int
// True if (x, y) lands on the "Add Zone" button. Pure.
bool addZoneHitTest(const KeymapEditorLayout& layout, int x, int y);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -83,4 +83,4 @@ Rect levelFillRect(const EmbedLayout& layout, double level) {
return Rect::ltrb(band.x, band.y, band.x + fillW, band.bottom());
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -73,4 +73,4 @@ int zoneAtPoint(const EmbedLayout& layout, const EmbedZone* zones, int zoneCount
// (rounded down). level <= 0 -> empty rect; level >= 1 -> the whole band. Pure.
Rect levelFillRect(const EmbedLayout& layout, double level);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -177,4 +177,4 @@ AmpEnvelope resolveNodeDrag(const AmpEnvelope& grabEnv, EnvNode node, const Rect
return out;
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -105,4 +105,4 @@ AmpEnvelope resolveNodeDrag(const AmpEnvelope& grabEnv, EnvNode node, const Rect
double totalSeconds, const EnvClampBounds& bounds,
int dxPixels, int dyPixels);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -2
View File
@@ -55,7 +55,6 @@ int levelToY(const Rect& area, double level) {
namespace {
EnvVertex vtx(EnvNode node, const Rect& area, double totalSeconds, double t, double level) {
EnvVertex v;
v.node = node;
@@ -172,4 +171,4 @@ std::vector<EnvVertex> buildEnvelopePolyline(const AmpEnvelope& env, const Rect&
: triggerPolyline(env, area, totalSeconds);
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -226,4 +226,4 @@ int timeToX(const Rect& area, double totalSeconds, double t);
// and the node hit-test share.
int levelToY(const Rect& area, double level);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -146,4 +146,4 @@ int resolveDragNote(const StripLayout& layout, int startNote, int dxPixels) {
return clampNote(startNote + shift);
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -128,4 +128,4 @@ int resolveDragNote(const StripLayout& layout, int startNote, int dxPixels);
// pastel spectral fill (S-VIEW-7). Pure — no layout required, no host types.
bool isNaturalKey(int note);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -153,4 +153,4 @@ DeckHit hitTestDeck(const DeckLayout& layout, int x, int y) {
return {};
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -130,4 +130,4 @@ struct DeckHit {
// Pure — the shell's routing entry point.
DeckHit hitTestDeck(const DeckLayout& layout, int x, int y);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -2
View File
@@ -99,7 +99,6 @@ double normDeg(double deg) {
return deg;
}
} // namespace
KnobGeometry computeKnob(const Rect& cell) {
@@ -157,4 +156,4 @@ int controlAtPoint(const std::vector<ControlRow>& rows, int x, int y) {
return -1;
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -177,4 +177,4 @@ double knobDragValue(double startValue, int dyPixels,
// toggleSegmentHitTest / knobDragValue over the ensuing drag) and commits.
int controlAtPoint(const std::vector<ControlRow>& rows, int x, int y);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -96,4 +96,4 @@ std::int64_t nearestZeroCrossing(const AudioSample* pcm, std::int64_t frames,
return t; // no sign change in the whole buffer -> keep the raw (clamped) target
}
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui
+1 -1
View File
@@ -82,4 +82,4 @@ std::int64_t resolveDragFrame(const Rect& area, std::int64_t frameCount, std::in
std::int64_t nearestZeroCrossing(const AudioSample* pcm, std::int64_t frames,
std::int64_t target);
} // namespace reasampler::instrument::ui
} // namespace reasampler::instrument::ui