Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

This commit is contained in:
2026-07-28 21:33:51 -04:00
parent 847936f813
commit 2d59bbe35d
131 changed files with 460 additions and 263 deletions
+1 -1
View File
@@ -151,4 +151,4 @@ int hitTestActionBar(int px, int py, const ActionBarRect& bar,
return -1; // inter-button/cluster gap or the overflow dead-zone — a clean miss
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -148,4 +148,4 @@ std::vector<ActionBarSlot> computeBarSlots(const ActionBarRect& bar,
int hitTestActionBar(int px, int py, const ActionBarRect& bar,
const std::vector<ClusterSpec>& clusters, const ActionBarSpec& spec);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -224,4 +224,4 @@ float compressAmplitudeForDisplay(float linear) {
return linear < 0.0f ? -clamped : clamped;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -175,4 +175,4 @@ constexpr float kDisplayFloorDb = -60.0f;
// (stays on the midline). Full-scale (|linear| == 1.0f) returns exactly ±1.0f.
float compressAmplitudeForDisplay(float linear);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -93,4 +93,4 @@ int hitTestSlot(int px, int py, const std::vector<SlotCellRect>& rects) {
return -1;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -144,4 +144,4 @@ std::vector<SlotCellRect> computeSlotRectsForDrop(int maxSlot, int panelWidth,
// callers reason in model slots.
int hitTestSlot(int px, int py, const std::vector<SlotCellRect>& rects);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -61,4 +61,4 @@ std::string formatSecondsMs(double lengthSeconds) {
return buf;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -52,4 +52,4 @@ std::string formatBarsBeats(const MusicalLength& m);
// * negative length is clamped to "0.000" (a length is never negative; defensive).
std::string formatSecondsMs(double lengthSeconds);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -105,4 +105,4 @@ int waveformColumnCount(const KitBox& box) {
return w > 0 ? w : 0;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -126,4 +126,4 @@ int hitTestListRow(int px, int py, const KitBox& list, int rowHeight, int rowCou
// identical whether bins == columns or bins == k*columns) and wastes memory and CPU.
int waveformColumnCount(const KitBox& box);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -51,4 +51,4 @@ PathList assemblePathList(const std::vector<ResolvedSample>& resolved) {
return out;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -129,4 +129,4 @@ struct PathList {
// case-insensitive dedup on Windows — the pure layer does not guess a platform rule).
PathList assemblePathList(const std::vector<ResolvedSample>& resolved);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -66,4 +66,4 @@ FooterHit hitTestFooterBar(int px, int py, const FooterBarLayout& layout) {
return FooterHit::None;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -103,4 +103,4 @@ FooterBarLayout computeFooterBar(const FooterRect& footer, const FooterBarSpec&
// mode_switch over the toggle box), then the Tail hit; this returns which region was struck.
FooterHit hitTestFooterBar(int px, int py, const FooterBarLayout& layout);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -18,4 +18,4 @@ bool tagButtonEnabled(const std::string& activeModeId, TagTarget target) {
return activeModeId != targetId;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -36,4 +36,4 @@ enum class TagTarget {
// disable an action the user can still reach), so a future added mode never dead-locks the bar.
bool tagButtonEnabled(const std::string& activeModeId, TagTarget target);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -39,4 +39,4 @@ bool hitTestMenuButton(int px, int py, const MenuButtonRect& button) {
py >= button.y && py < button.y + button.height;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -65,4 +65,4 @@ MenuButtonRect computeMenuButton(const MenuBarRect& bar, const MenuButtonSpec& s
// hit-test agree on the same pixels. An empty button never claims a point (always false).
bool hitTestMenuButton(int px, int py, const MenuButtonRect& button);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -36,4 +36,4 @@ bool hitTestPruneButton(int px, int py, const ButtonRect& button) {
py >= button.y && py < button.y + button.height;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -79,4 +79,4 @@ ButtonRect computePruneButton(const FooterRect& footer, const PruneButtonSpec& s
// so a suppressed button cannot be accidentally clicked.
bool hitTestPruneButton(int px, int py, const ButtonRect& button);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -109,4 +109,4 @@ TabHit hitTestTabStrip(int px, int py, const TabStripRect& strip, int tabCount,
return miss; // track dead space (no tab under the point)
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -124,4 +124,4 @@ struct TabHit {
TabHit hitTestTabStrip(int px, int py, const TabStripRect& strip, int tabCount,
const TabStripSpec& spec, int scrollOffset);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -190,4 +190,4 @@ double textFloor(TextClass cls) {
return cls == TextClass::Body ? 4.5 : 3.0;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -115,4 +115,4 @@ double contrastRatio(const KitColor& a, const KitColor& b);
// pair the kit actually draws.
double textFloor(TextClass cls);
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -50,4 +50,4 @@ TooltipBox computeTooltip(int anchorX, int anchorY, int anchorW, int anchorH,
return box;
}
} // namespace reasampler::ui
} // namespace reasampler::ui
+1 -1
View File
@@ -59,4 +59,4 @@ TooltipBox computeTooltip(int anchorX, int anchorY, int anchorW, int anchorH,
int textW, int textH, int clientW, int clientH,
const TooltipSpec& spec);
} // namespace reasampler::ui
} // namespace reasampler::ui