Q-W4: split actions.cpp into design_view_actions/bank_actions/prune_action + shared action_registry; bank verbs deduped into promptless bankOp* inner verbs in panel_bank_ops (one mutation home, two UX skins); command-id strings byte-identical; actions.h shim carrier retired
This commit is contained in:
+2
-3
@@ -16,7 +16,6 @@
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "actions.h" // persistBankOp — shared undo-block wrapper (R-B path)
|
||||
#include "core/version/app_version.h" // channelCommandId / channelActionName
|
||||
#include "core/wire/assignment_request.h" // pure (bankId, sampleId, generation) encode
|
||||
#include "core/model/bank_book.h" // BankBook, Bank, activeBankId / activeIndex
|
||||
@@ -435,7 +434,7 @@ void doImportFromMediaExplorer() {
|
||||
// The generation is bumped only when something NEW landed (a dedup collapse mutated nothing,
|
||||
// so it needs neither a bump nor a persist to resolve — the sample is already in ext-state).
|
||||
// If saveToActiveProject() no-ops (unsaved project), close with an empty label + zero flag so
|
||||
// REAPER discards the undo entry (the house pattern from actions.cpp). importFileIntoActiveBank
|
||||
// REAPER discards the undo entry (the house pattern from persistBankOp). importFileIntoActiveBank
|
||||
// already refuses on an unsaved project, so in practice the persist here succeeds.
|
||||
Undo_BeginBlock2(nullptr);
|
||||
bool persisted = true; // true when nothing needed persisting (dedup) — governs the label path
|
||||
@@ -508,7 +507,7 @@ void ingestDroppedFiles(const std::vector<std::string>& absolutePaths) {
|
||||
// One undo point for the whole drop, opened only if a NEW index entry was created (a
|
||||
// drop that only re-hit existing content mutated nothing on the index).
|
||||
// If saveToActiveProject() no-ops (unsaved project), we close with an empty label + zero
|
||||
// flag so REAPER discards the undo entry (house pattern from actions.cpp).
|
||||
// flag so REAPER discards the undo entry (house pattern from persistBankOp).
|
||||
if (importedNew > 0) {
|
||||
Undo_BeginBlock2(nullptr);
|
||||
// S9: one coalesced generation bump for the whole drop (>=1 new sample landed) so
|
||||
|
||||
Reference in New Issue
Block a user