fix: close five Θ-W6-T1 review minors — headroom figure, knob-face radius, degenerate band clamp

Aligns inKnobFace's hit radius with computeKnob's draw-side min(w,h) rule and adds a non-square-rect test; clamps halfSpan for degenerate waveform bands with a test; fixes stale docs/comments and annotates an uncommitted perf measurement.
2026-08-01 10:01:40 -04:00
parent ca464397b2
commit 47f2a063e7
8 changed files with 57 additions and 10 deletions
@@ -153,9 +153,11 @@ struct DeckFaceHit {
    bool inner = false;  // inside the concentric inner disc
 };

-// A point inside the circle inscribed in `knob`, boundary-EXCLUSIVE. THE target rule for the
-// reset gesture wherever a radial knob is drawn — the deck's own faces and the chrome's
-// preview-velocity dial both resolve through it, so one gesture cannot grow two target rules.
+// A point inside the circle inscribed in `knob` — radius is min(width, height)/2, same rule as
+// computeKnob's draw-side circle, so a non-square rect can never claim a hit past the drawn disc
+// — boundary-EXCLUSIVE. THE target rule for the reset gesture wherever a radial knob is drawn —
+// the deck's own faces and the chrome's preview-velocity dial both resolve through it, so one
+// gesture cannot grow two target rules.
 bool inKnobFace(const Rect& knob, int x, int y);

 // Resolved against the drawn CIRCLES, not the cell: a reset is aimed at a dial, so the label