daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix vacuous bounds test and stale/circular comments from the settle

Browse Source 
Replace the self-comparing render-window loop with a genuinely discriminating
floor-vs-exact check; correct two stale claims; mark the Auto/Manual floor-parity
premise as unverified; drop the STARTPOS/ENDPOS comment's circular justification.
This commit is contained in:
Daniel Harvey
2026-08-02 17:08:11 -04:00
parent 8331df2e91
commit 4c7e0507a1
4 changed files with 32 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_render_settings.cpp
+9 -6
View File
@@ -65,9 +65,11 @@ static void testRealtimeIsUnsupportedOffline() {
}
static void testEveryRenderSourceLabelIsPinnedVerbatim() {
// docs/VERIFICATION.md asks Daniel to report the refusal's `Render source:` line
// back verbatim, so every label is pinned to its literal — a typo in any of them
// breaks the report that quotes it, and only a literal catches that.
// docs/VERIFICATION.md's short-render bullet asks Daniel to report the refusal
// line back verbatim, and that line always carries the render source
// (render_bounds_gate.cpp appends "Render source: <label>."), so every label
// is pinned to its literal — a typo in any of them breaks the report that
// quotes it, and only a literal catches that.
CHECK(std::strcmp(renderSourceLabel(SourceMode::MasterMix), "master mix") == 0);
CHECK(std::strcmp(renderSourceLabel(SourceMode::TimeSelection), "master mix") == 0);
CHECK(std::strcmp(renderSourceLabel(SourceMode::SelectedTracks),
@@ -81,9 +83,10 @@ static void testEveryRenderSourceLabelIsPinnedVerbatim() {
static void testLabelsSeparateExactlyWhatTheRenderSeparates() {
// The labels partition the offline modes the way RENDER_SETTINGS does, and no
// finer: same bits => same words (MasterMix/TimeSelection both render the master
// mix, custom-time-bounded), different bits => different words. Naming two modes
// apart that render identically would put a distinction in a bug report that does
// not exist in the render.
// mix, unqualified — both hand their window over the same time-selection bounds
// mode), different bits => different words. Naming two modes apart that render
// identically would put a distinction in a bug report that does not exist in
// the render.
const SourceMode offline[] = {
SourceMode::MasterMix, SourceMode::TimeSelection, SourceMode::SelectedTracks,
SourceMode::SelectedItems, SourceMode::RazorArea,