From 5420550ff37448d5b547394f88dbb2356247a55b Mon Sep 17 00:00:00 2001 From: daniel-c-harvey Date: Thu, 30 Jul 2026 12:40:37 -0400 Subject: [PATCH] fix: correct app CMakeLists comments, drop dead bridge_marshal link edge --- src/app/CMakeLists.txt | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/app/CMakeLists.txt b/src/app/CMakeLists.txt index 300f75a..6688deb 100644 --- a/src/app/CMakeLists.txt +++ b/src/app/CMakeLists.txt @@ -1,8 +1,9 @@ -# The REAPER extension — a loadable module REAPER dlopen()s, never linked against. -# Its source list is app/ + shell/ only, so the paths below are rooted at src/ rather than -# being relative to this directory. Every core/ TU enters through a link edge instead: a TU -# compiled here AND linked from its library would be built twice under two different sets of -# per-target compile definitions and include dirs — two definitions of one symbol in one link. +# The REAPER extension — a loadable module REAPER dlopen()s, never linked against. Paths +# below are rooted at src/, not relative to this directory. +# No core/ TU is ever compiled into this source list; every core/ TU enters through a link edge +# instead. Compiling one here too would give it its own copy, built under this target's own +# compile definitions and include dirs — free to diverge from the library copy every other +# consumer (the _tests targets, reasampler_vst) links, with nothing to detect it. add_library(reaper_reasampler MODULE ${REASAMPLER_SRC_DIR}/app/main.cpp @@ -43,7 +44,7 @@ add_library(reaper_reasampler MODULE ${REASAMPLER_SRC_DIR}/shell/actions/instrument_drop_win.cpp ${REASAMPLER_SRC_DIR}/shell/persist/usage_scan.cpp ) -target_link_libraries(reaper_reasampler PRIVATE json wire file_bytes bank_model capture_paths peaks bank_grid mode_switch tab_strip view_mode_model view_tree guid_diff lane_keys insert_plan render_settings batch_capture tail_control capture_realtime bank_book wav_codec owned_manifest prune_reconcile prune_button app_version provenance drag_out instrument_drop theme component_geometry action_bar footer_bar overflow_menu mode_enable tooltip card_meta card_drag assignment_request bank_sync bridge_marshal sample_usage) +target_link_libraries(reaper_reasampler PRIVATE json wire file_bytes bank_model capture_paths peaks bank_grid mode_switch tab_strip view_mode_model view_tree guid_diff lane_keys insert_plan render_settings batch_capture tail_control capture_realtime bank_book wav_codec owned_manifest prune_reconcile prune_button app_version provenance drag_out instrument_drop theme component_geometry action_bar footer_bar overflow_menu mode_enable tooltip card_meta card_drag assignment_request bank_sync sample_usage) target_include_directories(reaper_reasampler PRIVATE ${SDK_INC} ${WDL_INC}) # OUTPUT_NAME is channel-derived; the CMake target name stays "reaper_reasampler" for both