fix(comments): correct two misleading impl comments in sampler_core (rescan vs tally; re-dispatch vs recursion)
This commit is contained in:
@@ -104,7 +104,7 @@ double AdsrEnvelope::tick() {
|
|||||||
// Fall through to Decay this frame so no extra unity sample is emitted for a
|
// Fall through to Decay this frame so no extra unity sample is emitted for a
|
||||||
// zero-length hold (preserving the exact pre-S15 sample-for-sample shape).
|
// zero-length hold (preserving the exact pre-S15 sample-for-sample shape).
|
||||||
level_ = 1.0;
|
level_ = 1.0;
|
||||||
// Re-dispatch by recursion-free goto-equivalent: evaluate Decay immediately.
|
// Single re-dispatch into Decay (bounded: Hold→Decay only; not a general recursion).
|
||||||
return tick();
|
return tick();
|
||||||
}
|
}
|
||||||
level_ = 1.0;
|
level_ = 1.0;
|
||||||
|
|||||||
@@ -516,8 +516,8 @@ private:
|
|||||||
// one per the documented policy. Always returns a valid index (maxVoices >= 1).
|
// one per the documented policy. Always returns a valid index (maxVoices >= 1).
|
||||||
std::size_t allocateVoice();
|
std::size_t allocateVoice();
|
||||||
|
|
||||||
// Count of active Preserve-engine voices (for the S16 Preserve cap). A cheap running tally
|
// Count of active Preserve-engine voices (for the S16 Preserve cap). Rescanned per note-on
|
||||||
// kept in sync at note-on/steal/free rather than rescanned per note.
|
// (cheap: bounded by maxVoices) rather than maintained as a running tally.
|
||||||
std::size_t activePreserveVoices() const;
|
std::size_t activePreserveVoices() const;
|
||||||
|
|
||||||
std::vector<Voice> voices_;
|
std::vector<Voice> voices_;
|
||||||
|
|||||||
Reference in New Issue
Block a user