fix(review): embed asymmetry comment, single-lock assign-marker, dedup-collapse test

2026-07-27 00:02:32 -04:00
parent 66d47fb410
commit 77e7c39171
3 changed files with 43 additions and 13 deletions
@@ -113,6 +113,10 @@ void ReaSamplerEmbed::maybeRefresh() {
    } else if (lastSeenBankGeneration_ < 0) {
        currentGen = 0;  // unprimed + no stamp (pre-S9): treat as generation 0 for the first read
    }
+    // Intentional asymmetry: a TRANSIENT bridge failure (readReasamplerExtState returned
+    // nullopt after we were already primed) leaves currentGen == lastSeenBankGeneration_,
+    // so the bank-blob read is skipped and the editor keeps its last-known sample list.
+    // A stale-but-intact list is better than clearing samples_ on every transient hiccup.

    if (lastSeenBankGeneration_ < 0 || currentGen != lastSeenBankGeneration_) {
        auto banks =