Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

tests/test_sampler_core.cpp

@@ -17,7 +17,7 @@
 // by the CMake target linking neither SDK — this file includes only sampler_core.h +
 // the standard library, which is itself the compile-time proof.
 
-#include "../src/vst/sampler_core.h"
+#include "../src/core/instrument/engine/sampler_core.h"
 
 #include <algorithm>
 #include <cmath>
@@ -25,6 +25,7 @@
 #include <vector>
 
 using namespace reasampler;
+using namespace reasampler::instrument::engine;
 
 static int g_fail = 0;
 #define CHECK(cond) do { if(!(cond)) { \
@@ -426,7 +427,7 @@ static void testNoteOffReleasesNewestSameNote() {
     // A LINEAR velocity curve keeps the two velocities distinguishable (velocity/127). The default
     // flat y=1 curve (S-VIEW-9 R10-F1) would render both at unity, collapsing the distinction this
     // note-off-selection test relies on — so we opt this zone back to the linear response.
-    km.zones[0].velocityCurve = vst::VelocityCurve::linear();
+    km.zones[0].velocityCurve = VelocityCurve::linear();
     VoiceEngine eng(8, km);
 
     std::size_t first  = eng.noteOn(60, velOld);  // older voice, lower gain
@@ -751,7 +752,7 @@ static void testVelocityDefaultCurveIsFlatUnity() {
 // (not a hardcoded map) drives the gain, and that eval is applied at note-on.
 static void testVelocityLinearCurveReproducesRamp() {
     Keymap km = Keymap::singleSampleChromatic(dcSample(100, 60));  // DC 1.0
-    km.zones[0].velocityCurve = vst::VelocityCurve::linear();
+    km.zones[0].velocityCurve = VelocityCurve::linear();
     {
         VoiceEngine eng(1, km);
         eng.noteOn(60, 127);
@@ -776,7 +777,7 @@ static void testVelocityLinearCurveReproducesRamp() {
 // curve's shaped value, not the linear one. Proves the whole curve, not just the endpoints, applies.
 static void testVelocityShapedCurveDrivesGain() {
     Keymap km = Keymap::singleSampleChromatic(dcSample(100, 60));  // DC 1.0
-    vst::VelocityCurve curve = vst::VelocityCurve::linear();
+    VelocityCurve curve = VelocityCurve::linear();
     curve.addPoint(64.0, 0.9);  // pull the mid-velocity response UP to 0.9
     km.zones[0].velocityCurve = curve;
     VoiceEngine eng(1, km);
@@ -1429,7 +1430,7 @@ static void testVelocityCurveAppliesUnderPreserve() {
         SampleData s = dcSample(4000, 60);
         s.play.pitchEngine = PitchEngine::Preserve;
         Keymap km = Keymap::singleSampleChromatic(std::move(s));
-        km.zones[0].velocityCurve = vst::VelocityCurve::linear();
+        km.zones[0].velocityCurve = VelocityCurve::linear();
         VoiceEngine eng(1, km, /*preserveCap=*/0, /*window=*/256);
         eng.noteOn(62, vel);  // transposed: the genuine shifter path (not the unity demotion)
         std::vector<AudioSample> out;
@@ -1578,7 +1579,7 @@ static void testMonoRepressHeldNoteMovesToTop() {
 static void testMonoRetriggerFallbackUsesOriginalVelocity() {
     SampleData s = dcLevelSample(200000, 1.0f, 60);
     Keymap km = Keymap::singleSampleChromatic(std::move(s));
-    km.zones[0].velocityCurve = vst::VelocityCurve::linear();  // gain = velocity/127
+    km.zones[0].velocityCurve = VelocityCurve::linear();  // gain = velocity/127
     VoiceEngine eng(4, km, 0, 0, VoiceMode::Mono, MonoTrigger::Retrigger);
     eng.noteOn(60, 32);                       // soft first note
     CHECK(approx(probeFrame(eng), 32.0 / 127.0, 1e-4));
@@ -1645,7 +1646,7 @@ static void testMonoLegatoRetunesWithoutReadRestart() {
     s.rootNote = 60;
     s.play.adsr = flatAdsr();
     Keymap km = Keymap::singleSampleChromatic(std::move(s));
-    km.zones[0].velocityCurve = vst::VelocityCurve::linear();
+    km.zones[0].velocityCurve = VelocityCurve::linear();
     VoiceEngine eng(2, km, 0, 0, VoiceMode::Mono, MonoTrigger::Legato);
     eng.noteOn(60, 127);                       // unity: read advances 1/frame, full gain
     std::vector<AudioSample> out;