docs: close out Phase L L3 — archive to COMPLETED, mark landed in design-language doc
L3 (VST editor + embed-strip restyle) is on dev. Append its COMPLETED entry and flip visual-design-language.md §5.3/5.4 from GATED to landed / Phase L complete. PLAN.md + CONTEXT.md L3 edits already landed via the S-VIEW commit.
This commit is contained in:
@@ -1484,6 +1484,57 @@ placement behavior; the "capture ≠ placement" principle is untouched.
|
||||
|
||||
---
|
||||
|
||||
## L3 — VST editor + embed-strip restyle
|
||||
**Goal:** Bring the ReaSampler 9000 VST editor (`IPlugView` LICE surface,
|
||||
`reasampler_editor.cpp`) and the S6 embed strip (`reasampler_embed.cpp`) up to the
|
||||
settled-and-revised **B + three-accent pastel** look via the L1 kit: kit cached-font
|
||||
`text()` (the kit's current face — no font change), kit component draws, the
|
||||
**REAPER-grey neutrals** (`bg/base #2b2b2b` / `bg/panel #333333` / `bg/cell #3a3a3a`)
|
||||
with the **three pastel accents** (primary lime / secondary teal / tertiary purple), the
|
||||
**pastel spectral keyboard strip + zone bars** (active zone lifts to `accent/primary` +
|
||||
a static glow) as the signature surface, and hover/pressed/drag interaction states
|
||||
throughout. Merged as `c53683e`. **L3 was the last remaining Phase L point — Phase L
|
||||
is now complete (L1, L2, L3, L4, L5, L6, L7 all landed).**
|
||||
**Verify (in DAW):** the VST editor + embed strip render in the settled B + three-accent
|
||||
pastel language through the L1 kit — kit AA cached-font text, gradient/rounded kit
|
||||
components, the pastel spectral keyboard strip, working hover/pressed/drag; the VST3
|
||||
class UID is unchanged (a visual refresh is not a compat event).
|
||||
|
||||
- [x] Route the VST editor's + embed strip's text through the kit's cached-font
|
||||
`text()`; retire their raw GDI `DrawTextA` path (retired in both shells).
|
||||
- [x] Retire the shells' **local pre-L1 palette** — the `kColBackground`/`kColCardBg`/
|
||||
`kColThumb`/… forest-green-on-charcoal constants block in `reasampler_editor.cpp`
|
||||
(and the mirrored constants in `reasampler_embed.cpp`) — and draw every surface
|
||||
through the L1 `theme` roles. One kit, one look; two palettes collapsed to one.
|
||||
- [x] Restyle the editor + embed components through the kit (capture-first browser
|
||||
search/tabs/thumbnails, channel toggles, ADSR + pitch sliders, Varispeed/Preserve mode
|
||||
toggles, zone bars, list rows, waveform + start/loop markers, segmented controls) in
|
||||
the B (Neon Console) palette with hover/pressed/drag states throughout.
|
||||
- [x] Apply **Direction C's pastel spectral treatment** to the keyboard strip + zone bars:
|
||||
hue-mapped zones as a pastel sweep anchored on the three accents; active zone lifts to
|
||||
`accent/primary` + a static glow (no animation); waveform + loop/start markers drawn
|
||||
through `drawWaveform` + `warn`/accent marker roles; VST3 class UID unchanged.
|
||||
|
||||
**Notes/decisions:**
|
||||
- **Full restyle, not a born-in-kit no-op.** The Phase S surfaces (`reasampler_editor.cpp`
|
||||
+ `reasampler_embed.cpp`) arrived on dev drawing flat `LICE_FillRect` blocks + raw GDI
|
||||
`DrawTextA`, off a local pre-L1 forest-green palette (`kColBackground` etc.) — the
|
||||
coordination contract's "born in the kit" branch did not occur. L3 performed the full
|
||||
restyle and reconciled the two palettes into one.
|
||||
- **Shell-side only.** All `src/vst/` UI geometry modules (`editor_geometry`,
|
||||
`keyboard_strip`, `waveform_view`, `capture_browser`, `param_slider`, `browser_scroll`,
|
||||
`embed_strip`) are pure geometry/hit-test — zero LICE, zero draw. L3 touched only the
|
||||
two draw shells; no geometry rework was needed.
|
||||
- **Beta title band — textual-only distinction (Daniel, 2026-07-27).** The S18 beta
|
||||
channel title band gets no distinct visual accent; L3 restyles it in the standard B
|
||||
pastel palette and the beta-vs-stable distinction stays purely textual (the
|
||||
channel-derived plugin name via `app_version`, as before). No channel-specific accent
|
||||
color. Closes the one open fork from the L3 readiness review.
|
||||
- **VST3 class UID unchanged.** A visual refresh is not a compat event; RT/`process`
|
||||
path untouched; pure geometry modules remained pure throughout.
|
||||
|
||||
---
|
||||
|
||||
# Phase S — MIDI-playback instrument (native VST3 sampler; a second build artifact)
|
||||
|
||||
> **Landed on dev (merged 2026-07-27); DAW verification pending Daniel's smoke test.**
|
||||
|
||||
Reference in New Issue
Block a user