Ξ-W2-T1 re-review cleanup: soften ordering claim, bound bake guard fields, dedup gain/play-mode rationale, quiet foreign WrongProject noise

src/core/instrument/bake/bake_render.cpp

@@ -21,7 +21,14 @@ constexpr std::int64_t kBlockFrames = 512;
 BakeAudio renderBake(SampleData sample, const BakePlan& plan, double masterGainLinear) {
     BakeAudio out;
     if (!sample.playable() || plan.totalFrames <= 0 || plan.sampleRate <= 0) return out;
-    if (plan.leadInFrames < 0 || plan.renderFrames() > kMaxBakeFrames) return out;
+    // Each field bounded BEFORE the sum: renderFrames() adds them, and a hand-built plan
+    // (planBake already bounds both — bake_plan.cpp) could otherwise carry leadInFrames
+    // near INT64_MAX and signed-overflow inside the guard meant to catch exactly that.
+    if (plan.leadInFrames < 0 || plan.leadInFrames > kMaxBakeFrames ||
+        plan.totalFrames > kMaxBakeFrames) {
+        return out;
+    }
+    if (plan.renderFrames() > kMaxBakeFrames) return out;
 
     // The live block is the audio thread's moving target; a render that observed it would
     // depend on what the user happened to be dragging. The dialed values are already in
@@ -67,8 +74,11 @@ BakeAudio renderBake(SampleData sample, const BakePlan& plan, double masterGainL
     const auto lead = static_cast<std::size_t>(plan.leadInFrames);
     const auto total = static_cast<std::size_t>(plan.totalFrames);
     out.interleaved.resize(total * static_cast<std::size_t>(channels));
-    // A flat multiply, not the processor's per-sample ramp: the gain is constant for the
-    // whole render, which is exactly what that ramp exists to converge to.
+    // Printed here rather than left for the processor: resetAfterBake hands master gain
+    // back to unity, so a render that only summed voices would return every iteration
+    // shifted by 1/gain, and a gain dialed to silence would come back at full level. A flat
+    // multiply, not the processor's per-sample ramp: the gain is constant for the whole
+    // render, which is exactly what that ramp exists to converge to.
     const auto gain = static_cast<AudioSample>(masterGainLinear);
     for (std::size_t f = 0; f < total; ++f) {
         out.interleaved[f * channels] = left[lead + f] * gain;