daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs: the picker was never a deviation, it was a regex miss in the plan

Browse Source
This commit is contained in:
Daniel Harvey
2026-08-02 16:19:22 -04:00
parent 24569956cf
commit a2ee5ff69d
1 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/COMPLETED.md
+9 -7
View File
@@ -974,13 +974,15 @@ reaches the destination only through a `commit()` rename — process-crash atomi
not power-loss atomic, deliberately, since an `fsync` over a whole sample bank is a not power-loss atomic, deliberately, since an `fsync` over a whole sample bank is a
real stall) and the rollback journal (`package_rollback`'s `LandedFileJournal`, real stall) and the rollback journal (`package_rollback`'s `LandedFileJournal`,
citing the `prune_fs.cpp` carve-out rather than restating it, disarmed only after citing the `prune_fs.cpp` carve-out rather than restating it, disarmed only after
the caller's own write has returned success). **Deviation from spec:** the plan the caller's own write has returned success). `package_pickers` rides REAPER's own
called for asymmetric pickers — REAPER's `GetUserFileNameForRead` for import, Win32 `GetUserFileName` for both directions, as specified (mode 1 import, mode 0 export)
`GetSaveFileNameW`/SWELL `BrowseForSaveFile` for export, reasoning that the REAPER — the plan's "REAPER has no save picker" finding was a regex miss in the original
API has no save picker. The landed `package_pickers` instead rides `GetUserFileName` research, not a real gap, so there was no asymmetric-picker deviation to land: no
for both directions (mode 1 import, mode 0 export) — no platform split, since SWELL `BrowseForSaveFile`, no Win32 `GetSaveFileNameW`, no `GetUserFileNameForRead`
`main.cpp` already aborts extension load if any needed API pointer fails to (the SDK header marks it superseded). REAPER owning the dialog on every platform is
resolve. Both pickers are `[verify — DAW]`, never exercised in a live REAPER why there's no platform split; that's separate from `main.cpp` already aborting
extension load if any needed API pointer fails to resolve, which is why no fallback
path is needed. Both pickers are `[verify — DAW]`, never exercised in a live REAPER
session. session.
**Ε-W1-T3 — `import-origin-kind`.** `OriginKind::PackageImport` appended to the **Ε-W1-T3 — `import-origin-kind`.** `OriginKind::PackageImport` appended to the