fix: close review findings on the velocity-curve deck and bipolar curves

Cancels the curve-node drag whenever the popup closes so Esc mid-drag can't alias the amp curve; generalizes CurveTarget routing to one switch; fixes stale/overstated comments; clamps a pre-v12 depth fold; adds deck-inertness and filter-fold test coverage.
2026-07-31 19:46:37 -04:00
parent 9d38f87a2d
commit cfb53aade3
22 changed files with 223 additions and 99 deletions
@@ -43,7 +43,8 @@ int valueToY(const VelocityCurve::Box& box, double value, CurveDomain d) {

 VelocityCurve VelocityCurve::flat() {
    VelocityCurve c;
-    c.points_ = {{kVelMin, kCurveYMax}, {kVelMax, kCurveYMax}};
+    const double n = curveNeutral(CurveDomain::Unipolar);
+    c.points_ = {{kVelMin, n}, {kVelMax, n}};
    return c;
 }

@@ -56,7 +57,8 @@ VelocityCurve VelocityCurve::linear() {
 VelocityCurve VelocityCurve::zero() {
    VelocityCurve c;
    c.domain_ = CurveDomain::Bipolar;
-    c.points_ = {{kVelMin, 0.0}, {kVelMax, 0.0}};
+    const double n = curveNeutral(CurveDomain::Bipolar);
+    c.points_ = {{kVelMin, n}, {kVelMax, n}};
    return c;
 }