fix: close review findings on the velocity-curve deck and bipolar curves

Cancels the curve-node drag whenever the popup closes so Esc mid-drag can't alias the amp curve; generalizes CurveTarget routing to one switch; fixes stale/overstated comments; clamps a pre-v12 depth fold; adds deck-inertness and filter-fold test coverage.
2026-07-31 19:46:37 -04:00
parent 9d38f87a2d
commit cfb53aade3
22 changed files with 223 additions and 99 deletions
@@ -17,33 +17,10 @@ using namespace reasampler::ui;
 using namespace reasampler::instrument::ui;

 bool ReaSamplerEditor::deckKnobDisabled(int id) const {
-    switch (static_cast<ParamControl>(id)) {
-        case ParamControl::kPitchEnvAttack:
-        case ParamControl::kPitchEnvHold:
-        case ParamControl::kPitchEnvDecay:
-        case ParamControl::kPitchEnvDepth:
-            return !params_.play.pitchEnv.enabled;
-        case ParamControl::kFilterMorph:
-        case ParamControl::kFilterCutoff:
-        case ParamControl::kFilterQ:
-        case ParamControl::kFilterDrive:
-        case ParamControl::kFilterModAmt:
-        case ParamControl::kFilterKeyTrack:
-        // The filter's velocity curve sits in the VELOCITY group but is a filter parameter:
-        // it goes inert with every other one, so no surface can reach a param the knobs can't.
-        case ParamControl::kFilterVelCurve:
-        case ParamControl::kFilterEnvAttack:
-        case ParamControl::kFilterEnvHold:
-        case ParamControl::kFilterEnvDecay:
-        case ParamControl::kFilterEnvSustain:
-        case ParamControl::kFilterEnvRelease:
-        case ParamControl::kFilterTrigAttack:
-        case ParamControl::kFilterTrigHold:
-        case ParamControl::kFilterTrigDecay:
-            return !params_.play.filter.enabled;
-        default:
-            return false;
-    }
+    // Thin int-id wrapper over the pure, CTest-covered predicate — see deckKnobInert
+    // (deck_groups.h) for which cells go inert and why.
+    return deckKnobInert(static_cast<DeckParam>(id), params_.play.pitchEnv.enabled,
+                         params_.play.filter.enabled);
 }

 bool ReaSamplerEditor::mouseDownDeck(const FaceLayout& fl, int x, int y) {