build: split the 1423-line root CMakeLists into per-directory files with shared target helpers

src/core/instrument/CMakeLists.txt

@@ -0,0 +1,3 @@
+add_subdirectory(engine)
+add_subdirectory(map)
+add_subdirectory(ui)

src/core/instrument/engine/CMakeLists.txt

@@ -0,0 +1,26 @@
+# The shifter is hand-rolled rather than WDL_SimplePitchShifter because that header drags
+# <windows.h> in via wdltypes.h, which cannot enter the pure engine.
+reasampler_pure_library(pitch_shift SOURCES pitch_shift.cpp LINK PUBLIC peaks)
+# Links only pitch_shift: linking more would break the plain-data-boundary proof — and
+# specifically the compile-time proof it does not drag in the WDL <windows.h> chain.
+reasampler_test(pitch_shift LINK pitch_shift)
+
+reasampler_pure_library(velocity_curve SOURCES velocity_curve.cpp)
+# Links only velocity_curve, deliberately not editor_geometry: the proof the engine can
+# depend on the curve without inheriting the editor's layout types.
+reasampler_test(velocity_curve LINK velocity_curve)
+
+reasampler_pure_library(master_gain SOURCES master_gain.cpp)
+reasampler_test(master_gain LINK master_gain)
+
+# Two TUs on the engine's own responsibility seam (per-note setup vs. note routing and
+# block render). The per-sample render half stays inline in voice.h precisely so this TU
+# boundary costs the hot path nothing.
+reasampler_pure_library(sampler_core
+    SOURCES voice.cpp voice_engine.cpp
+    LINK PUBLIC peaks pitch_shift velocity_curve)
+# Links only sampler_core: linking more would break the plain-data-boundary proof — a VST3
+# or REAPER type reaching the core would fail to compile or link here.
+reasampler_test(sampler_core LINK sampler_core)
+
+add_subdirectory(filter)

src/core/instrument/engine/filter/CMakeLists.txt

@@ -0,0 +1,15 @@
+# Control mapping, SVF coefficients, morph weights, and the filter type each get their own
+# TU; VoiceFilter::process stays header-inline so the kernel still inlines at the call site.
+reasampler_pure_library(filter SOURCES
+    filter_params.cpp
+    filter_coeffs.cpp
+    filter_morph.cpp
+    voice_filter.cpp)
+
+# Four test targets along the module's own seams so each asserts one domain. filter_tests
+# alone owns the analytic reference and the steady-state gain measurement — a forked copy of
+# a measurement reference is a worse defect than a long file.
+reasampler_test(filter_params LINK filter)
+reasampler_test(filter_morph LINK filter)
+reasampler_test(filter_state LINK filter)
+reasampler_test(filter LINK filter)

src/core/instrument/map/CMakeLists.txt

@@ -0,0 +1,31 @@
+reasampler_pure_library(bridge_marshal SOURCES bridge_marshal.cpp)
+reasampler_test(bridge_marshal LINK bridge_marshal)
+
+reasampler_pure_library(trigger_seam SOURCES trigger_seam.cpp)
+# Links only trigger_seam — not even editor_geometry — the plainest data-boundary proof
+# available.
+reasampler_test(trigger_seam LINK trigger_seam)
+
+reasampler_pure_library(bank_sync
+    SOURCES bank_sync.cpp
+    LINK PUBLIC assignment_request PRIVATE wire)
+# Links only bank_sync (+ its assignment_request dep): linking more would break the
+# plain-data-boundary proof.
+reasampler_test(bank_sync LINK bank_sync)
+
+# The state codec is shared with the extension's preset-blob path, so it must link WITHOUT
+# the voice engine: velocity_curve (the curve field) and master_gain (the wire gain cap) only.
+reasampler_pure_library(component_state_io
+    SOURCES component_state_io.cpp
+    LINK PUBLIC velocity_curve master_gain)
+# Links only component_state_io, deliberately no sampler_core/pitch_shift: the structural
+# proof the codec is engine-free, which is what keeps engine object code out of the extension.
+reasampler_test(component_state_io LINK component_state_io)
+
+# The mapping's product is plain SampleData, so the voice engine is not a dependency.
+reasampler_pure_library(sample_map
+    SOURCES sample_map.cpp
+    LINK PUBLIC bank_book wav_codec velocity_curve peaks)
+# Links only sample_map + component_state_io: the same plain-data-boundary proof, spanning
+# both halves of the mapping/codec split where the frozen-format assertions live.
+reasampler_test(sample_map LINK sample_map component_state_io)

src/core/instrument/ui/CMakeLists.txt

@@ -0,0 +1,48 @@
+# The geometry vocabulary every instrument UI module speaks (the Rect alias + contains())
+# is header-only, hence INTERFACE.
+add_library(editor_geometry INTERFACE)
+target_include_directories(editor_geometry INTERFACE ${REASAMPLER_SRC_DIR})
+
+reasampler_pure_library(sample_bands SOURCES sample_bands.cpp LINK PUBLIC editor_geometry)
+reasampler_test(sample_bands LINK sample_bands)
+
+reasampler_pure_library(sample_chrome SOURCES sample_chrome.cpp LINK PUBLIC sample_bands)
+reasampler_test(sample_chrome LINK sample_chrome)
+
+reasampler_pure_library(embed_strip SOURCES embed_strip.cpp LINK PUBLIC editor_geometry)
+reasampler_test(embed_strip LINK embed_strip)
+
+reasampler_pure_library(capture_browser SOURCES capture_browser.cpp LINK PUBLIC editor_geometry)
+reasampler_test(capture_browser LINK capture_browser)
+
+reasampler_pure_library(keyboard_strip SOURCES keyboard_strip.cpp LINK PUBLIC editor_geometry)
+reasampler_test(keyboard_strip LINK keyboard_strip sample_bands sample_chrome)
+
+# sample_bands is PRIVATE: the lane split is used internally and nothing in the public
+# header needs it.
+reasampler_pure_library(waveform_view
+    SOURCES waveform_view.cpp
+    LINK PUBLIC editor_geometry peaks PRIVATE sample_bands)
+# sample_bands is linked directly here because the test exercises the lane metrics that
+# waveform_view does not re-export.
+reasampler_test(waveform_view LINK waveform_view sample_bands)
+
+reasampler_pure_library(browser_scroll
+    SOURCES browser_scroll.cpp
+    LINK PUBLIC capture_browser sample_chrome)
+reasampler_test(browser_scroll LINK browser_scroll)
+
+reasampler_pure_library(param_slider SOURCES param_slider.cpp LINK PUBLIC editor_geometry)
+reasampler_test(param_slider LINK param_slider)
+
+reasampler_pure_library(envelope_overlay SOURCES envelope_overlay.cpp LINK PUBLIC editor_geometry)
+reasampler_test(envelope_overlay LINK envelope_overlay)
+
+reasampler_pure_library(envelope_edit SOURCES envelope_edit.cpp LINK PUBLIC envelope_overlay)
+reasampler_test(envelope_edit LINK envelope_edit)
+
+reasampler_pure_library(knob_deck SOURCES knob_deck.cpp LINK PUBLIC editor_geometry)
+reasampler_test(knob_deck LINK knob_deck)
+
+reasampler_pure_library(curve_popup SOURCES curve_popup.cpp LINK PUBLIC editor_geometry)
+reasampler_test(curve_popup LINK curve_popup)