daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ψ-W1-T3 review remediation: soften the double-fire claim to unspecified-by-SDK, mark the unload mirror [verify — DAW], fix stale comment, drop redundant assertions, dedupe hook-partitioning comments, drop what-comment; file the action_registry test-seam deferral.

Browse Source
This commit is contained in:
Daniel Harvey
2026-08-01 20:13:13 -04:00
parent 72b870459c
commit d589b99705
6 changed files with 48 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_app_version.cpp
+1 -17
View File
@@ -159,7 +159,7 @@ static void testMediaExplorerImportIdsAreDistinctAndChannelIsolated() {
// The Media-Explorer import publishes into TWO action sections, and a custom_action
// idStr must be unique across all sections — so the two entries carry two suffixes.
// Both are FOREVER-STABLE per channel. Composed from the SHIPPED constants and checked
// against spelled-out literals, so a suffix edit in ingest.cpp fails here.
// against spelled-out literals, so a suffix edit in ingest.h fails here.
const std::string mainId = channelCommandId(kIngestImportMediaExplorerId);
const std::string mxId = channelCommandId(kIngestImportMediaExplorerMxId);
@@ -174,22 +174,6 @@ static void testMediaExplorerImportIdsAreDistinctAndChannelIsolated() {
CHECK(channelActionName("import Media Explorer file into selected track") ==
"ReaSampler: import Media Explorer file into selected track");
}
// Distinctness is what keeps the two dispatch hooks from both claiming one command:
// hookcommand owns the Main id, hookcommand2 owns the Media Explorer id. A suffix
// collapse would silently double-fire the import.
CHECK(mainId != mxId);
// Cross-channel isolation: this build's ids must NOT collide with the other channel's,
// or a beta install would rebind the stable keymap's entries. Asserted against the
// opposite channel's literals, which is the collision that would actually occur.
if (isBeta()) {
CHECK(mainId != "CEREBELLUM_REASAMPLER_INGEST_IMPORT_MEDIA_EXPLORER");
CHECK(mxId != "CEREBELLUM_REASAMPLER_INGEST_IMPORT_MEDIA_EXPLORER_MX");
} else {
CHECK(mainId != "CEREBELLUM_REASAMPLER_BETA_INGEST_IMPORT_MEDIA_EXPLORER");
CHECK(mxId != "CEREBELLUM_REASAMPLER_BETA_INGEST_IMPORT_MEDIA_EXPLORER_MX");
}
}
static void testStampClassifiesAsStampedOnOwnChannel() {