Restore the bank fold and usage publish to the resume path, guard setActive against repeats, and make the meter fold's bound literal
The resume also hands back to a full reload when the fold moves the loaded capture's decode source, so the refs table and the audio cannot skew.
This commit is contained in:
+9
-7
@@ -242,17 +242,19 @@ alpha and this entry is re-filed against the new value.
|
||||
|
||||
## The editor's drag state machine has no seam, and `reasampler_editor.h` is near the ceiling
|
||||
|
||||
**Context (Γ-W3, meter re-review).** `reasampler_editor.h` stands at **563 lines** against the
|
||||
~600-line ceiling — 37 lines of margin — and it keeps growing because every new surface on the
|
||||
**Context (Γ-W3, meter re-review).** `reasampler_editor.h` stands at **564 lines** against the
|
||||
~600-line ceiling — 36 lines of margin — and it keeps growing because every new surface on the
|
||||
Sample face adds its transient state there. The obvious seam is the drag state machine: `drag_`
|
||||
plus the per-gesture anchors it is read against.
|
||||
|
||||
**Why it was declined rather than taken.** `drag_` has **42 references across 13 shell TUs**
|
||||
(measured over `src/shell/instrument/*.cpp`; the declaration in the header is additional), and
|
||||
every input TU both writes it and branches on it. Extracting it is a real refactor of the
|
||||
editor's input half, not a header move — and doing it inside a wave whose subject is the MASTER
|
||||
deck would have put an unrelated high-blast-radius change in the same diff. Declining was right;
|
||||
leaving it unrecorded was not.
|
||||
(measured over `src/shell/instrument/*.cpp`; the declaration in the header is additional). Of
|
||||
the six input TUs, three write it and branch on it (`editor_input`, `_waveform`, `_curve`) and
|
||||
three only write it (`_chrome`, `_browse`, `_deck`) — which is what makes the anchor invariant
|
||||
observed rather than enforced. Extracting it is a real refactor of the editor's input half, not
|
||||
a header move — and doing it inside a wave whose subject is the MASTER deck would have put an
|
||||
unrelated high-blast-radius change in the same diff. Declining was right; leaving it unrecorded
|
||||
was not.
|
||||
|
||||
**The shape a fix would take.** A `DragState` type owning the kind plus its anchor payload,
|
||||
with the input TUs mutating it through named transitions rather than assigning `drag_` and its
|
||||
|
||||
Reference in New Issue
Block a user