Fix embed use-after-free, restore golden fixture + refs tests, drop dead note_entry

2026-07-30 08:01:22 -04:00
parent 8d4ccbf841
commit e304f2b031
13 changed files with 241 additions and 244 deletions
@@ -165,8 +165,8 @@ public:
    void setPreviewVelocity(std::uint8_t velocity);

    // Voice-system parameters (per-instance), guarded by voiceParamsMutex_, not read on the
-    // audio thread — each setter rebuilds via rebuildVoiceEngine (already-decoded keymap, no
-    // bridge/WAV re-read) through the same drain-slot swap, so a change never cuts a tail.
+    // audio thread — each setter rebuilds via rebuildVoiceEngine (already-decoded SampleData,
+    // no bridge/WAV re-read) through the same drain-slot swap, so a change never cuts a tail.
    int voiceCount();
    void setVoiceCount(int count);        // clamped to kMinVoiceCount..kMaxVoiceCount
    VoiceMode voiceMode();