Archive Milestone 4 in docs

Move completed M4 (persist) from PLAN.md to COMPLETED.md with a decisions
note (GUID identity, Save-As copy, MarkProjectDirty, known limitation);
update CLAUDE.md repo-identity to M0-M4 complete.

CLAUDE.md

@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## Repo identity and current state
 
-The CMake project and binary are now named `reaper_reasampler`. This is **ReaSampler** — a per-project audio sample-bank capture tool. The MPE modules (`mpe_model`, `mpe_view`) have been removed. M0–M3 are complete: `bank_model` (Sample metadata + BankIndex with JSON round-trip), `peaks` (waveform min/max bin computation), and the `capture` shell's offline-render path (DAW-verified spike: master-mix / time-selection capture to a project-relative bank at 32-bit float WAV, non-destructive) are all implemented and tested. The remaining REAPER-facing shells (`insert`, `bank_panel`, `persist`, `actions`) and the realtime backend are being built out per CONTEXT.md / PLAN.md. The *discipline* — pure REAPER-free testable core split from REAPER-facing shells — is **preserved** throughout.
+The CMake project and binary are now named `reaper_reasampler`. This is **ReaSampler** — a per-project audio sample-bank capture tool. The MPE modules (`mpe_model`, `mpe_view`) have been removed. M0–M4 are complete: `bank_model` (Sample metadata + BankIndex with JSON round-trip), `peaks` (waveform min/max bin computation), the `capture` shell's offline-render path (DAW-verified spike: master-mix / time-selection capture to a project-relative bank at 32-bit float WAV, non-destructive), and `persist` (BankIndex ↔ project ext state: `SetProjExtState`/`GetProjExtState` under namespace `"reasampler"`, GUID-based project identity, project-relative path resolution, Save-As bank relocation with copy semantics) are all implemented and tested. The remaining REAPER-facing shells (`insert`, `bank_panel`, `actions`) and the realtime backend are being built out per CONTEXT.md / PLAN.md. The *discipline* — pure REAPER-free testable core split from REAPER-facing shells — is **preserved** throughout.
 
 CONTEXT.md is the authoritative spec and build roadmap. Read it first for any non-trivial task. Every REAPER API name cited there is correct-by-intent; verify argument order, types, and flag values against `vendor/reaper-sdk/sdk/reaper_plugin_functions.h` before use.
 

COMPLETED.md

@@ -95,3 +95,23 @@ added silence without an explicit tail).
   (open question) and confirm it runs headless.
 - [x] Populate a `Sample` from the finished file; hand to `bank_model`; console-log.
 - [x] Verify bit-identical repeats and exact-bounds by hand on a known range.
+
+---
+
+## Milestone 4 — persist (index ↔ project ext state)
+**Goal:** Write the `BankIndex` JSON to project ext state, reload on project open;
+project-relative path resolution. CONTEXT.md §persist, §Persistence & paths.
+**Verify (in DAW):** Index survives Save / Save As / close+reopen; **bank travels
+with the .rpp**; **relative paths only** in the persisted index (Save As to a new
+folder still resolves the bank).
+
+- [x] `SetProjExtState` / `GetProjExtState` under namespace `"reasampler"`.
+- [x] Bank-folder resolution from the current project path
+  (`EnumProjects` / `GetProjectPathEx`); store under a project-relative subfolder.
+- [x] Reload-on-open; confirm survival across Save / Save As.
+
+**Notes/decisions:**
+- Storage: `SetProjExtState` / `GetProjExtState`, namespace `"reasampler"`, keys `bank_index` (serialized JSON) and `project_guid`; relative paths only in the persisted index.
+- Project identity: keyed off a **minted GUID** stored in ext state (REAPER exposes no native per-project GUID), not the raw `ReaProject*` — a recycled pointer cannot misread a project switch as a Save-As.
+- Save-As: **copy** semantics (Daniel's decision) — the `reasampler_bank/` folder is copied under the new `.rpp`; the old project's bank stays intact. Every ext-state write calls `MarkProjectDirty` so captures/GUID changes flush on the normal save.
+- Known limitation (narrow, accepted): if a user does Save-As, closes the copy *without saving*, then reopens that copy to a *different* folder while the original is also open, identities can collide. Force-saving after Save-As would close the hole but was rejected as violating non-destructive.

PLAN.md

@@ -14,18 +14,6 @@ it here and appends it to `COMPLETED.md`.
 
 ---
 
-## Milestone 4 — persist (index ↔ project ext state)
-**Goal:** Write the `BankIndex` JSON to project ext state, reload on project open;
-project-relative path resolution. CONTEXT.md §persist, §Persistence & paths.
-**Verify (in DAW):** Index survives Save / Save As / close+reopen; **bank travels
-with the .rpp**; **relative paths only** in the persisted index (Save As to a new
-folder still resolves the bank).
-
-- [ ] `SetProjExtState` / `GetProjExtState` under namespace `"reasampler"`.
-- [ ] Bank-folder resolution from the current project path
-  (`EnumProjects` / `GetProjectPathEx`); store under a project-relative subfolder.
-- [ ] Reload-on-open; confirm survival across Save / Save As.
-
 ## Milestone 5 — bank_panel (docked grid)
 **Goal:** Docked LICE-drawn grid: thumbnails (from `peaks`), audition,
 multi-select, keyboard navigation. Reuses the docking setup from the retired