Ψ-W1-T2 review remediation: solo restore drops on visible-in-target, not parked; N-mode segments read dead when unroutable

Fixes a hidden-parent solo replay that could silence the mix. Also closes the N-mode segment silent no-op, amends the invariant comment, trims view.cpp under 600 lines, hedges two SDK inferences, drops a dead null-check.
2026-08-01 20:13:10 -04:00
parent 9c234c2e6b
commit f2cdf676f3
17 changed files with 137 additions and 73 deletions
@@ -112,9 +112,9 @@ void drawFooter(LICE_IBitmap* bmp, int w, int h) {
            const SegmentRect& s = segs[static_cast<std::size_t>(i)];
            const Mode& mode = modes[static_cast<std::size_t>(i)];
            const bool active = mode.id == activeId;
-            // A switch is refused while the transport runs, so an unreachable segment
-            // draws dead rather than inviting a click that would silently do nothing.
-            const bool live = modeSegmentEnabled(active, g_panel.modeSwitchBlocked);
+            // Disabled/dead rationale: core/ui/footer_bar.h.
+            const bool live = modeSegmentEnabled(active, g_panel.modeSwitchBlocked,
+                                                 modeActivateCommandId(mode.id) != 0);
            const InteractionState state =
                active ? InteractionState::Active
                       : (live ? hoverState(g_panel.hovered, HoverKind::ModeSegment, i)