reasampler

Remediate Ε-W3-T1 package-compat-fixtures review findings

2026-08-02 17:19:57 -04:00

package_fixtures.h

Freeze the package compatibility corpus: real .rsbank bytes proving both ladder directions, every truncation site, and the round trip

2026-08-02 17:19:57 -04:00

test_action_bar.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_app_version_padding.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_app_version.cpp

Ψ-W1-T3 review remediation: soften the double-fire claim to unspecified-by-SDK, mark the unload mirror [verify — DAW], fix stale comment, drop redundant assertions, dedupe hook-partitioning comments, drop what-comment; file the action_registry test-seam deferral.

2026-08-01 20:13:13 -04:00

test_assignment_request.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bake_hold.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_bake_plan.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_bake_render.cpp

Print the limiter through the bake's master stage, compensating its lookahead so an engaged bake is the approved sound and a bypassed one is unchanged

2026-08-02 20:57:29 -04:00

test_bake_reset.cpp

Close Γ-W3-T2 review remediation: widen the bake-reset test's per-parameter coverage, correct four overclaiming comments, state the stage-time ceiling's disposition, and fix a missing include

2026-08-02 13:52:32 -04:00

test_bake_window.cpp

Print the limiter through the bake's master stage, compensating its lookahead so an engaged bake is the approved sound and a bypassed one is unchanged

2026-08-02 20:57:29 -04:00

test_bake_wire.cpp

Take the read-back back out of the persist; a write verdict belongs only where evidence crosses the plugin boundary

2026-08-02 13:42:51 -04:00

test_bank_book.cpp

Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

2026-07-28 21:34:09 -04:00

test_bank_grid.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bank_model.cpp

Merge Ψ-W2-T2: a bit-identical capture collapses to one lossless mono channel

2026-08-01 22:23:06 -04:00

test_bank_package.cpp

Close the RSBK name-collision class: ASCII case folding, UTF-8 well-formedness, nested-path traversal

2026-08-02 17:19:29 -04:00

test_bank_sync.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_batch_capture.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bridge_marshal.cpp

Q-W6: registration table (OCP) in main.cpp; bank verbs -> shell/bank_ops(Session&); persist.h + wav_trim + namespaces.h shims deleted; 61/61

2026-07-29 13:40:09 -04:00

test_browser_scroll.cpp

Retire the zone system: one capture = one parameter set, and re-seam the engine and Sample face into bands

2026-07-30 07:15:54 -04:00

test_capture_browser.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_capture_name.cpp

Render in place: a track's output to a new sibling, source to the bench

2026-08-02 14:47:59 -04:00

test_capture_paths.cpp

Render in place: a track's output to a new sibling, source to the bench

2026-08-02 14:47:59 -04:00

test_capture_realtime.cpp

Q-W3: main.cpp → pointers+entry+dispatch via 4 capture hoists; one pure wav_codec RIFF owner; ICaptureBackend deleted; capture_realtime rename + finalize split; shared stampCaptureSample; makeUniqueTag gains monotonic counter (fixes same-second batch collisions). 60/60 green.

2026-07-29 11:33:28 -04:00

test_card_drag.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_card_meta.cpp

Name captures after their source track: label and filename both, on every interactive mint site, and show the name on the panel card

2026-08-01 21:46:53 -04:00

test_component_geometry.cpp

Ω-W1-T5: one overlay↔waveform mapping, and loop marks that tell the truth about their mode

2026-08-03 12:39:41 -04:00

test_component_state_io.cpp

Merge Γ-W2-T2: an explicit loop enable, four named marks with grabbable caps, and the crossfade painted where it is heard

2026-08-02 13:52:32 -04:00

test_curve_law.cpp

Fix envelope-overlay knot/trace disagreement on odd pixel spans

2026-08-02 13:47:19 -04:00

test_curve_popup.cpp

fix: close review findings on the velocity-curve deck and bipolar curves

2026-07-31 19:46:37 -04:00

test_curve_tessellate.cpp

Γ-W1-T3: staged contour traces draw the curve their exponent defines

2026-08-02 13:47:19 -04:00

test_deck_groups_measured.cpp

fix(instrument-ui): distinguish Disabled from Off, add hover cue to mode toggles, close review minors

2026-08-03 13:43:38 -04:00

test_deck_groups_state.cpp

deck: filter mod moves to FILTER ENV, cell runs centre in their reserves, two-segment toggles become single buttons, deck focuses its overlay

2026-08-03 13:12:28 -04:00

test_deck_groups.cpp

deck: filter mod moves to FILTER ENV, cell runs centre in their reserves, two-segment toggles become single buttons, deck focuses its overlay

2026-08-03 13:12:28 -04:00

test_deck_values.cpp

fix(instrument-ui): distinguish Disabled from Off, add hover cue to mode toggles, close review minors

2026-08-03 13:43:38 -04:00

test_drag_out.cpp

Ψ-W1-T4 remediation: gate silent arrange drops, pin surface totality, hedge unverified SDK claims, close comment/exception-safety minors

2026-08-01 20:13:17 -04:00

test_embed_strip.cpp

Retire the zone system: one capture = one parameter set, and re-seam the engine and Sample face into bands

2026-07-30 07:15:54 -04:00

test_envelope_edit.cpp

Fix envelope-overlay knot/trace disagreement on odd pixel spans

2026-08-02 13:47:19 -04:00

test_envelope_overlay.cpp

Fix envelope-overlay knot/trace disagreement on odd pixel spans

2026-08-02 13:47:19 -04:00

test_export_bank.cpp

Close bank-export review findings: name-cap underflow, double overwrite prompt, test scope

2026-08-02 17:19:30 -04:00

test_export_plan.cpp

Close bank-export review findings: name-cap underflow, double overwrite prompt, test scope

2026-08-02 17:19:30 -04:00

test_file_bytes.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_filter_morph.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_filter_params.cpp

Add an Oberheim-SEM morph law to the SVF filter: HP->notch->LP alongside HP->BP->LP, selected at prepare() time, free on the per-sample path

2026-07-30 11:04:20 -04:00

test_filter_state.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_filter.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_footer_bar.cpp

Ψ-W1-T2 review remediation: solo restore drops on visible-in-target, not parked; N-mode segments read dead when unroutable

2026-08-01 20:13:10 -04:00

test_fx_offline.cpp

Split unidentified from missing FX in Design View drop report, fix message + console pop

2026-08-02 18:51:41 -04:00

test_guid_diff.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_import_landing.cpp

import: remediate review findings — ledger gate, docs, message split

2026-08-02 17:19:30 -04:00

test_import_plan.cpp

import: remediate review findings — ledger gate, docs, message split

2026-08-02 17:19:30 -04:00

test_insert_plan.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_instrument_drop.cpp

Ψ-W1-T4: resolve drop targets per move, not once — every surface gets a defined outcome, a cue, and no silent no-op

2026-08-01 19:43:37 -04:00

test_json.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_keyboard_strip.cpp

Widen the deck row block to 1028 so the filter tie-line is exact, and accumulate the meter's block peaks instead of sampling one in 47

2026-08-02 13:56:15 -04:00

test_knob_deck.cpp

deck: filter mod moves to FILTER ENV, cell runs centre in their reserves, two-segment toggles become single buttons, deck focuses its overlay

2026-08-03 13:12:28 -04:00

test_lane_keys.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_limiter.cpp

Γ-W1-T2: the published GR meter reads the limiter, not the mute

2026-08-02 13:50:13 -04:00

test_live_delivery.cpp

Bound the automation hold to the window the model has not caught up on, and make that authority model stated, enforced and tested

2026-08-02 17:16:02 -04:00

test_live_params.cpp

Close pass four: undetented host curve read, LiveValues guard, ordering assert, static-lane fix, docs

2026-08-02 18:22:21 -04:00

test_loop_marks.cpp

Loop-crossfade-ux review fixes: parked-drag no longer fakes LOOP OFF, waveform label contrast fixed, hover memoizes its bank read

2026-08-02 13:52:32 -04:00

test_loop_span.cpp

loop: fix the crossfade seam's residual discontinuity, plus six review minors

2026-07-31 17:59:58 -04:00

test_master_gain.cpp

Report the instrument's automatable parameters to the host under a frozen id table, in signal-flow order, with real units

2026-08-02 15:14:16 -04:00

test_master_meter.cpp

Ω-W1-T3 review fixes: skip meter invalidate when covered; push fast-path predicates into core

2026-08-03 13:31:50 -04:00

test_meter_accumulate.cpp

Restore the bank fold and usage publish to the resume path, guard setActive against repeats, and make the meter fold's bound literal

2026-08-02 14:06:37 -04:00

test_meter_ballistics.cpp

Γ-W1-T2: the master bus — a true-peak limiter whose ceiling is a theorem, the meter's published half, and the plugin's first PDC report

2026-08-02 13:50:13 -04:00

test_mode_enable.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_mode_switch.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_musical_division.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_note_program.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_origin_ledger.cpp

docs: fix overclaiming OriginKind comment and trim restated test comments

2026-08-02 17:19:29 -04:00

test_overflow_menu.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_package_compat.cpp

Remediate Ε-W3-T1 package-compat-fixtures review findings

2026-08-02 17:19:57 -04:00

test_package_format.cpp

Close the RSBK name-collision class: ASCII case folding, UTF-8 well-formedness, nested-path traversal

2026-08-02 17:19:29 -04:00

test_package_io.cpp

Close bank-export review findings: name-cap underflow, double overwrite prompt, test scope

2026-08-02 17:19:30 -04:00

test_package_manifest.cpp

Close the RSBK name-collision class: ASCII case folding, UTF-8 well-formedness, nested-path traversal

2026-08-02 17:19:29 -04:00

test_package_rollback.cpp

Close package fs review findings: readRange bounds, picker ext, non-ASCII tests

2026-08-02 17:19:29 -04:00

test_package_round_trip.cpp

Remediate Ε-W3-T1 package-compat-fixtures review findings

2026-08-02 17:19:57 -04:00

test_param_format.cpp

Close pass four: undetented host curve read, LiveValues guard, ordering assert, static-lane fix, docs

2026-08-02 18:22:21 -04:00

test_param_id.cpp

Service both VST3 parameter channels, and promote pitch key-track and Trigger length so all 44 ids issue

2026-08-02 16:22:17 -04:00

test_param_live.cpp

Bound the automation hold to the window the model has not caught up on, and make that authority model stated, enforced and tested

2026-08-02 17:16:02 -04:00

test_param_merge.cpp

Bound the automation hold to the window the model has not caught up on, and make that authority model stated, enforced and tested

2026-08-02 17:16:02 -04:00

test_param_slider.cpp

One taper, one modifier law: extract param_taper, raise the stage ceiling to 10 s, and make the AHDSR schematic axis the taper itself

2026-08-02 13:47:19 -04:00

test_param_taper.cpp

Bake window: derive it from the rate the voice actually reads at, so a dialled Rate or downward Pitch no longer truncates the file

2026-08-02 13:52:31 -04:00

test_param_units.cpp

Bound the automation hold to the window the model has not caught up on, and make that authority model stated, enforced and tested

2026-08-02 17:16:02 -04:00

test_peaks.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_period_detect.cpp

Close Γ-W1-T7 re-review: pitch-sync cadence math, floor-model regression check, evidence-count fix, one-home comments

2026-08-02 13:52:31 -04:00

test_period_render_integration.cpp

Close Γ-W1-T7 re-review: pitch-sync cadence math, floor-model regression check, evidence-count fix, one-home comments

2026-08-02 13:52:31 -04:00

test_pitch_shift.cpp

Close Γ-W1-T7 re-review: pitch-sync cadence math, floor-model regression check, evidence-count fix, one-home comments

2026-08-02 13:52:31 -04:00

test_preserve_low_frequency.cpp

Close Γ-W1-T7 re-review: pitch-sync cadence math, floor-model regression check, evidence-count fix, one-home comments

2026-08-02 13:52:31 -04:00

test_provenance.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_prune_button.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_prune_reconcile.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_render_settings.cpp

Fix vacuous bounds test and stale/circular comments from the settle

2026-08-02 17:08:11 -04:00

test_render_window.cpp

Fix vacuous bounds test and stale/circular comments from the settle

2026-08-02 17:08:11 -04:00

test_resample_name.cpp

Ξ-W2-T1: the resample bake chain — instrument renders, extension banks, one click re-points and resets

2026-08-01 16:26:28 -04:00

test_sample_bands.cpp

Reflow the deck into two categorical rows plus a double-height MASTER bus deck

2026-08-02 13:52:33 -04:00

test_sample_chrome.cpp

deck: filter mod moves to FILTER ENV, cell runs centre in their reserves, two-segment toggles become single buttons, deck focuses its overlay

2026-08-03 13:12:28 -04:00

test_sample_map.cpp

Restore the bank fold and usage publish to the resume path, guard setActive against repeats, and make the meter fold's bound literal

2026-08-02 14:06:37 -04:00

test_sample_usage.cpp

tracking: one ledger, one authority — prune protection and replace-vs-add answered from the same records, fail-safe on unreadable state

2026-07-30 19:44:11 -04:00

test_sampler_core.cpp

Bake window: derive it from the rate the voice actually reads at, so a dialled Rate or downward Pitch no longer truncates the file

2026-08-02 13:52:31 -04:00

test_sampler_filter.cpp

instrument: the filter's velocity depth knob returns and multiplies the bipolar curve; the pre-v12 lift is a pure domain re-tag

2026-07-31 20:24:40 -04:00

test_slot_map.cpp

Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

2026-07-28 21:34:09 -04:00

test_solo_cache.cpp

Ψ-W1-T2 review remediation: solo restore drops on visible-in-target, not parked; N-mode segments read dead when unroutable

2026-08-01 20:13:10 -04:00

test_spline_edit.cpp

Loop: an explicit enable, four named marks with grabbable caps, and the crossfade painted where it is actually heard

2026-08-02 13:52:32 -04:00

test_spline_egs.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_staged_envelopes.cpp

instrument: fix AHD node-tracking/tie-break/live-latch defects and close staged-envelope-curve test gaps

2026-07-31 09:52:17 -04:00

test_stroke_aa.cpp

fix: enlarge every sub-2px stroker width to 2px, per Daniel's ruling

2026-08-01 15:11:58 -04:00

test_tab_strip.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_tail_control.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_tempo.cpp

note: close every value type's domain at construction, so resolveNote is finite for every constructible input

2026-07-30 20:37:12 -04:00

test_theme.cpp

Loop-crossfade-ux review fixes: parked-drag no longer fakes LOOP OFF, waveform label contrast fixed, hover memoizes its bank read

2026-08-02 13:52:32 -04:00

test_time_stretch.cpp

Γ-W1-T5: a real Preserve time-stretcher — write rate is duration, tap rate is pitch

2026-08-02 13:47:19 -04:00

test_tooltip.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_track_topology.cpp

Render in place: a track's output to a new sibling, source to the bench

2026-08-02 14:47:59 -04:00

test_tracking_authority.cpp

Ξ-W2-T1: the resample bake chain — instrument renders, extension banks, one click re-points and resets

2026-08-01 16:26:28 -04:00

test_trigger_seam.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_velocity_curve.cpp

fix: close Θ-W7-T1 review — scaling guard, opacity claims, two vacuous test fixes

2026-08-01 13:45:43 -04:00

test_view_fx_park.cpp

Drain deferred FX parks before the view model is serialized; re-validate track handles per intent; pin the restore-plan round trip

2026-08-03 14:08:28 -04:00

test_view_mode_model.cpp

Key Design View's parked FX-offline state to the FX's own GUID, not its slot

2026-08-02 18:31:08 -04:00

test_view_tree.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_wav_codec.cpp

Collapse a dual-mono resample bake to one channel, like every other capture

2026-08-02 18:31:05 -04:00

test_waveform_view.cpp

fix(instrument): bound the waveform zero-crossing snap to a pixel radius so single-cycle loop marks stop teleporting

2026-08-03 15:15:25 -04:00

test_wire.cpp

Q-W2v: split VST god-modules — editor 8 face-axis TUs (+pure layout hoist), processor 3 TUs, component_state_io codec split (extension drops the voice engine), zone_params.h, core/wire putLE; formats frozen, 61/61 green

2026-07-29 11:29:36 -04:00

tone_metrics.h

Γ-W1-T7: make Preserve's splices pitch-synchronous — the jump is a whole number of the source's own period, detected once at load

2026-08-02 13:50:14 -04:00