Merge - Streaming Winner #2

Merged

daniel merged 86 commits from dev into master 2026-06-27 02:47:43 +00:00

Conversation 0 Commits 86 Files Changed 134

+12843 -1112

daniel commented 2026-06-27 02:47:16 +00:00

Owner

Copy Link

Copy Source

No description provided.

daniel added 86 commits 2026-06-27 02:47:16 +00:00

feature: Phase 18.1 — derive Opus 320 + seek-index sidecar at ingest ... 33d6f34d8a

Background-job transcode (ffmpeg/libopus) after source store; pure C# Ogg
walker builds the 0.5s-bucketed granule→byte seek index + captures the
OpusHead/OpusTags setup header into a per-track sidecar in a new track-opus
vault. Best-effort, additive, regenerated on replace-audio.

fix: Wave 18.1 review — pre-skip subtraction, t=0 anchor, PreSkip in sidecar, stderr on cancel 6add30a4ff

Merge Phase 18.1 (Opus ingest transcode + seek-index sidecar) into streaming-overhaul b3dadbb572

provision ffmpeg on DeepDrftAPI host for Opus transcode ... ba064cc136

Phase 18.1 needs ffmpeg (libopus). Add it to bootstrap.sh apt prereqs and a
preflight guard in install.sh; resolves via the systemd user unit's default
PATH (/usr/bin), no config change.

Merge ffmpeg host provisioning into streaming-overhaul e845dc3496

feature: Opus format resolution + sidecar lookup contract (Phase 18.2) 19793ba1c3

Merge Phase 18.2 (Opus format resolution + sidecar lookup contract) into streaming-overhaul e807ddb91b

feature: Phase 18.3 — Opus delivery transport (?format= stream + seek sidecar endpoint) 740d01a67f

feature: OpusFormatDecoder — Ogg-page-aligned segmenting, sidecar parser, accurate index-based seek (Phase 18.4) 261289c1b8

Merge Phase 18.3 (Opus delivery transport) into streaming-overhaul 8afcd3784f

Merge Phase 18.4 (OpusFormatDecoder + index-based seek) into streaming-overhaul dce5530890

Wire Opus end-to-end playback + Backfill-Opus action (Phase 18.5) ... 2bde4908d7

Player picks Opus when the browser can decode it and a sidecar exists (else lossless), injecting the sidecar before stream init; seek reuses the same format. Adds the Backfill-Opus bulk API endpoint + CMS action.

Merge Phase 18.5 (Opus end-to-end integration + Backfill-Opus) into streaming-overhaul e5366bc4ec

feature: Phase 18.6 Track A — public Settings menu + streaming-quality toggle c63c7ca033

feature: CMS Opus status surfaces — backfill missing-N badge + upload Post-Processing phase (18.6) 59f48bb8cb

Merge Phase 18.6 Track B (CMS Opus status: backfill badge + Post-Processing) into streaming-overhaul ab75bbf6c1

remediate: replace eval cookie writes with safe JS helper + add tests (18.6 Track A) ... 77c6c42c94

Both SettingsCookieService and DarkModeCookieService now call window.DeepDrftSettings.setCookie (new Interop/settings/settings.ts) instead of eval. New tests cover SettingsServiceBase parse/format round-trip and the PreferenceAwareStreamingPlayerService invariant (Lossless skips probe; LowData inherits base).

Merge Phase 18.6 Track A (public Settings menu + streaming-quality toggle) into streaming-overhaul 81d4b42b72

fix: replace hand-assembled Opus probe blob with real ffmpeg/libopus output ... 5b78efaad4

Previous probe sample had invalid Ogg page CRC32s, so Chrome/Firefox rejected it and the capability check always returned false. New 176-byte libopus sample has verified-correct CRCs. Adds structural-validity tests.

Merge Opus capability-probe fix into streaming-overhaul d0118997b6

Replace broken per-segment Opus decode with WebCodecs AudioDecoder streaming pipeline 7f3fb74126

fix: AC9 seek fine re-sync + deterministic decoder drain (WebCodecs Opus) ... 5a75da1769

Seek now trims the lead-in so playback lands at the requested time, not the page start; decoder drain polls decodeQueueSize (bounded) instead of a single timeout. Minor cleanups.

Merge WebCodecs streaming Opus decoder (+ AC9 seek re-sync) into streaming-overhaul d80b777e9f

Fix Opus duration reporting so seekbar and visualizer work ... eb58ae4a72

Surface the sidecar duration on the first Opus chunk instead of gating it on the first decoded buffers; C# locks UI Duration on chunk 1, and async WebCodecs decode left it at 0 — killing seek and the duration-gated visualizer.

Merge Opus duration/seek/visualizer fix into streaming-overhaul 8902ce4d63

docs: record Phase 18 (Opus low-data streaming) in COMPLETED; stage PLAN for Phase 21 bbcf8be677

docs: reconcile Phase 21 spec with as-built Phase 18 (two decode paths) ... ccf7d3dbe3

Window both the WAV StreamDecoder and Opus WebCodecs paths feeding one PlaybackScheduler — shared eviction, per-path back-pressure; reuse the now-live index-driven Opus seek for refill. Drops stale approximate-seek language; adds OQ6/OQ7.

Add partial eviction to PlaybackScheduler (Phase 21.1) ... ed606d94c7

Drop already-played buffers from the front while advancing the time
anchor so position/index bookkeeping stays exact. Shared by both decode
paths, no format branch. Back-retain is a config seam for 21.2.

Reconcile eviction comment wording; add handleSourceEnded cascade test (Phase 21.1) ... 07f29a8216

The inclusive <= bound is correct; comments now say 'at or behind'. New
test drives eviction through the real onended trigger with a live mid-array
source pinning the frontier.

Merge Phase 21.1 (PlaybackScheduler partial eviction) into streaming-overhaul a2becf45d6

Phase 21.2: back-pressure to bound the unplayed decoded region ... 518479e7ae

Shared scheduler fill signal (forward water-marks + hard byte cap) pauses
the C# read loop above high-water and, for Opus, stops the demux/decode
feed so WebCodecs queues stay near-empty. Routes through the existing
cancellation discipline; releases the latch on clear/seek.

21.2 review remediation: pause-spin, OQ7 comment, rename, C2 cross-check ... 29e8747c69

Skip the back-pressure interop poll while paused (UC5). Document complete()
draining the stash in full by design. Rename scheduler isProductionPaused to
evaluateProductionPause (latch-advancing); window exposure name unchanged.

Merge Phase 21.2 (streaming back-pressure) into streaming-overhaul 121983b19d

Phase 21.3: seek-back-past-window refill + clean refill-failure recovery ... af4cb186f3

Seek-back past the retained tail reuses the existing seek-beyond-buffer
Range path (per-path resolver). A failed refill now halts the scheduler
into a paused-but-loaded state (AC6) instead of a silent false end.

21.3 review fixes: guard superseded-seek failures; restore post-recovery retry ... b93881cd66

C6/AC8: IsStillActiveSeek() predicate guards all three SeekBeyondBuffer
failure exits, so a superseded seek never recovers over a newer seek's
state. AC6: empty scheduler routes to seekBeyondBuffer so a same-target
retry (seek or play) refetches instead of no-oping.

Merge Phase 21.3 (seek-back-past-window refill + AC6 recovery) into streaming-overhaul 9c95a5f23e

Enable WASM response streaming on audio media fetch ... c7629c15a4

Without SetBrowserResponseStreamingEnabled the browser buffers the whole
body before yielding, so the Phase 21.2 read-loop pause backpressured an
already-downloaded payload. Set it on both the initial and seek/refill
requests; safe no-op on the SSR path.

Add [BP-DIAG] back-pressure instrumentation for Phase 21.4 browser run ... 369cb86437

Temporary, grep-tagged diagnostics at the read-loop pause, the scheduler
latch, and the chunk-result path to show whether ProductionPaused latches,
reaches C#, and parks the loop. Strip once the cause is confirmed.

Merge Phase 21.4 streaming fix + back-pressure diagnostics into streaming-overhaul def297e7d9

Anchor ambient visualizer to viewport bottom; occlude via z-index not clip ... cb899a2913

Drop the --player-height bottom inset so the fixed visualizer fills the
viewport; the inset player bar no longer leaves a page-background gap. The
spacer now occludes via opaque page-surface + z-index. Visualizer no longer
reads --player-height, so spacer.ts coalescing is removed.

Fix stale spacer-observe comment: drop visualizer/clipping ref, name spacer as sole consumer adbd376d42

Phase 21 Direction B: bound network memory via Range-segmented forward fetch ... 11faf8888f

Replace the open-ended forward GET with sequential bounded bytes=start-end
segments, the next fetched only when the scheduler drains below low-water,
so the browser holds ~one segment regardless of file size. Seek converges
on the same loop. Strip BP-DIAG.

Fix truncated-segment and mid-stream failure paths in segmented loop ... e7762e35e8

cursor>=totalLength is the sole forward-EOF test; a short non-final body is
a truncation error, not EOF. Mid-stream forward-load failures now invoke
RecoverFromFailedRefill so the scheduler halts instead of a silent false end.
Two regression tests pin both paths.

Restore IsStreamingMode on recovery; guard superseded-load else-branch ... cc9d20184d

RecoverFromFailedRefill now sets IsStreamingMode=true so the in-place
seek-retry route isn't wedged. The generic-catch unload path is gated on
the loadCts identity, so a superseded load no longer clobbers a newer
operation's state.

Merge Phase 21 Direction B (Range-segmented forward fetch) into streaming-overhaul c1e6930c70

docs: record Phase 21 (windowed streaming) as landed; note Direction A to B pivot ... 036ee1f78e

Move Phase 21 from PLAN to COMPLETED with the as-built record, and annotate
the spec that Direction B shipped after WASM fetch buffering defeated A.

Bound decoded forward fill per chunk in streaming read loop ... aeec582957

The inter-segment back-pressure gate matched WAV byte density but let a 4MB Opus segment (~100s at 320kbps) decode eagerly into main-process RAM, OOMing the tab with HW accel off. Drain per chunk past high-water, gated on playback start. Adds load-generation diagnostics for the double-load hypothesis.

Merge streaming OOM cross-format memory bound into streaming-overhaul 8206c0bdaf

docs: record streaming raw-queue and per-chunk memory bounds ... 7adc35dd5d

Document the three-layer memory bound (raw queue, decoded queue, network) in the streaming seam after the HW-accel-off OOM fix landed on streaming-overhaul.

Apply stream-quality change live by reloading at current position ... d686fe48ce

Finish the Settings "Apply" behavior so changing streaming quality mid-track
switches format immediately instead of only persisting the cookie for the next
play.

- SettingsMenu reads the AudioPlayerProvider cascade and threads the player into
  StreamQualitySetting as an explicit parameter (the MudMenu panel portals to
  MudPopoverProvider, outside the cascade scope, so a [CascadingParameter] there
  lands null). StreamQualitySetting's Apply persists the cookie, then asks the
  player to reload preserving position.

- Add a "load at timestamp" path to the player rather than restart-from-0-then-
  seek (which audibly played the start and raced the just-started scheduler into
  a crash). ReloadPreservingPositionAsync loads the track in the newly-resolved
  format beginning DIRECTLY at the saved position:
    * new JS resolveStreamOffset(position) resolves the file-absolute byte offset
      with no playback/buffer state (Opus from its sidecar immediately; WAV after
      a header probe),
    * StartFromPositionAsync converges onto the existing seek/refill loop
      (RunSegmentedStreamAsync with a non-null seekPosition) so the decoder
      reinitializes for a header-less Range continuation and starts playback at
      the target,
    * ProbeHeaderAsync feeds the byte-0 segment to the decoder WITHOUT starting
      playback until the WAV header parses (bounded by 256 KB); the probe buffers
      are dropped by the continuation's clearForSeek, so nothing is audible.

- IStreamingPlayerService gains ReloadPreservingPositionAsync; the QueueService
  test fake implements it.

Collapse duplicate same-track streaming loads to enforce one load per play ... be9de8d77c

A second LoadTrackStreaming for the same in-flight track (UI double-fire, queue re-entry, or JS false-end auto-advance) is now dropped; a different-track load still supersedes. Targets the Opus double-load; keeps load-gen diagnostics.

Merge Opus single-load guard (instrument double-load) into streaming-overhaul 8a6acd5f5f

fix(audio): align AudioContext to 48kHz up front for Opus streams ... 0800167511

Opus resolved its 48kHz context lazily on the first chunk, close()ing and rebuilding the live graph mid-decode. Move the recreate into initializeStreaming so it runs before any bytes flow; the lazy call early-returns. WAV path unchanged.

Merge Opus 48kHz up-front AudioContext init (root-cause fix) into streaming-overhaul 8fa37f995b

Remove harmful single-load guard; instrument reload/reset path for double-header-parse hunt e98e616997

Merge guard revert + reload-path instrumentation into streaming-overhaul 3aed5c129f

fix(audio): guard underrun/stream-complete against false end-of-playback ... 67422e922d

pause() clears underrun_ so setStreamComplete can't fire TrackEnded while paused; resetToStart() resets streamComplete. Prior fix: underrun_ park + streamComplete discriminator prevent the Opus-startup false-end. Tests: 18 PlaybackScheduler cases including pause-during-underrun and underrun->resume->genuine-end-once.

Merge false end-of-playback fix (Opus startup underrun gating) into streaming-overhaul 48e58c266d

fix(api): stream audio store path to eliminate whole-file buffering (OOM) ... 79bbbd4956

Processors now emit a ProcessedAudio plan with a streamed writer instead of a whole-file AudioBinary; vault writes stream via RegisterResourceStreamingAsync. Header parsing is bounded. Wave 2 (waveform/Opus) still re-reads the full file by design.

fix(vault): atomic streamed write via temp→rename, suppress OCE log noise ... beec36a382

AddEntryStreamingAsync now writes to a temp file in the same vault directory,
renames it into place (POSIX rename(2) — atomic on Linux), and updates the
index only after the rename succeeds. A client disconnect or I/O fault during
the write leaves the original backing file intact and the index unchanged; the
temp file is cleaned up best-effort on failure. Fixes the data-corruption
regression on the replace path where a cancelled write could truncate the live
backing file after the index update and FileMode.Create already ran.

Also filters OperationCanceledException from error-level logging in
RegisterResourceStreamingAsync — a normal client disconnect is not an error.

Two tests added to AudioStoreStreamingTests covering cancel and fault on the
replace path.

Fix complete-without-start hang for ultra-short tracks; add Opus rebuffer hysteresis ... 4ab430d232

Tracks whose total audio falls below the playback-start threshold (Opus <1s lead, WAV <6 buffers) silently hung loaded-but-not-playing. After MarkStreamCompleteAsync, call TryStartPlaybackAsync when _streamingPlaybackStarted is still false so the scheduler drains its buffers and fires onPlaybackEnded exactly once.

Merge Wave 1: stream audio store path to fix large-upload OOM into dev aa0b64329f

Merge Opus rebuffer hysteresis + ultra-short-track start fix into streaming-overhaul f0d1463619

Stream the waveform compute so large uploads no longer buffer the whole file (Wave 2 OOM) 9347f11ff0

audio: widen forward decode cushion 30/15->60/30s + add [BP-DIAG] back-pressure instrumentation ... 61e185a2f7

Byte cap (96MB) unchanged as the hard OOM bound; the wider time window only lets sparse Opus use existing memory headroom to ride out decode jitter. Diag logs pin whether the block is back-pressure or decode throughput.

Merge forward-cushion widening + back-pressure diagnostics into streaming-overhaul 76f7f389a3

Merge Wave 2: stream waveform compute to bound large-upload memory into dev 5d9f410cd8

fix: logging levels in Prod 4fe2d564d9

docs: reflect streaming upload store path and waveform compute (OOM fix) 9bfa921703

Auto-throttle visualizer under sustained Opus decode pressure; strip streaming investigation instrumentation 374f09150f

Merge visualizer auto-throttle under decode pressure + instrumentation strip into streaming-overhaul 0e8b85bbcb

Merge visualizer-viewport-framing: anchor ambient visualizer to viewport bottom 1aef30f67d

Detect HW acceleration; default lava off on software renderer; release probe WebGL context ... 020a945843

Probes UNMASKED_RENDERER_WEBGL once per page via a throwaway WebGL context; defaults the lava subsystem off on a positive software-renderer match or total WebGL failure; releases the throwaway context via WEBGL_lose_context after reading the renderer string to avoid exhausting the browser's per-page context limit.

Merge HW-acceleration detection (default lava off on software renderer) into streaming-overhaul d7a373cdb0

docs: record streaming-stabilization arc (Opus + HW-accel-off fixes) ... 634eb611eb

Document the back-pressure water marks, genuine end-of-playback gating, rebuffer hysteresis, 48kHz Opus pre-align, decodePressure auto-throttle, and HW-accel detection / lava default-off, plus the off-main-thread-decode fallback note.

Merge streaming-overhaul into dev (Opus low-data streaming, windowed streaming, HW-accel-off stabilization) c1f2cafd8b

Stream Opus transcode source and encoded output; removes last store-path OOM ... 4351ae04be

Source read via streamed vault open + bounded staging copy (index-only duration/extension); encoded output walked from a bounded stream (new OggOpusParser.WalkAsync, byte-identical to the buffer oracle) and stored via streaming vault write. Adds parity tests.

Merge opus-transcode-streaming into dev (stream Opus transcode store path; last store-path OOM fix) a98cef1ba7

docs: record Opus transcode store-path streaming 1e17ffc380

Stream Opus/derived read path: serve from seekable disk FileStream, never a whole-file byte[]; HasOpusAsync is index-only d72263aea1

fix: move LogInformation inside disposal guard in both GetTrack streaming arms ... afa862a67b

Prevents an OS handle leak if the logger throws after the FileStream is opened but before File() takes ownership. Also corrects a stale "finally block" comment in the lossless arm — it has always been a catch.

Merge opus-read-streaming into dev (stream Opus/derived read path; last read-path OOM fix + logger-leak hardening) bf5b314aed

docs: record Opus/derived read-path streaming and index-only opus-status ca44979b08

fix(telemetry): first-party fetch for play/share, beacon only on unload ... 2af0d8650b

Route normal play closes (end/switch/stop) and all shares through a same-origin
HttpClient POST so privacy-hardened browsers stop blocking them; keep sendBeacon
for the tab-unload edge. Rename the JS module off telemetry/beacon to session/
lifecycle so the retained fallback isn't name-matched. No new data or identifiers.

Merge telemetry-transport-resilience into dev (first-party fetch for play/share; beacon only on unload) 6a043b622e

docs: fix stale anonid.ts path after telemetry module rename 8d1272e36f

daniel merged commit aa4fae1faf into master 2026-06-27 02:47:43 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

daniel (Daniel Harvey)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: daniel/deepdrft#2