daniel/reasampler
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: close round-3 review findings — smallest-target-first, residue test fix, extraction

Browse Source 
Waveform overlay now resolves node/tab/marker click collisions by target area instead of check order; residue test now uses a distinguishing fixture; Gate-unavailable-while-drawn logic extracted to one pure helper shared by resolvePlay and applyControl.
This commit is contained in:
Daniel Harvey
2026-07-31 23:44:05 -04:00
parent c3d67bc3da
commit 757e1585d6
11 changed files with 255 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/instrument/ui/CMakeLists.txt
+4 -2
View File
@@ -24,8 +24,10 @@ reasampler_pure_library(waveform_view
SOURCES waveform_view.cpp
LINK PUBLIC editor_geometry peaks PRIVATE sample_bands)
# sample_bands is linked directly here because the test exercises the lane metrics that
# waveform_view does not re-export.
reasampler_test(waveform_view LINK waveform_view sample_bands)
# waveform_view does not re-export. velocity_curve is linked for the smallest-target-first
# arbitration tests, which pin the geometric facts editor_input_waveform.cpp's node/tab/marker
# resolution depends on (the shell itself has no test target).
reasampler_test(waveform_view LINK waveform_view sample_bands velocity_curve)
reasampler_pure_library(browser_scroll
SOURCES browser_scroll.cpp