Commit Graph

409 Commits

Author SHA1 Message Date
daniel 4f51758ad6 fix(drag_out): return E_OUTOFMEMORY on GlobalLock failure in HDropDataObject::GetData 2026-07-26 20:06:55 -04:00
daniel 34df2563e4 feat(m11): native OS drag-out of bank samples (copy-only)
Pure drag_out (gesture boundary + path-list assembly) + Windows OLE
CF_HDROP / SWELL file-list shell; bank_panel hands off when a dragged
selection leaves the client area. COPY-ONLY mask; internal drag intact.
2026-07-26 20:02:46 -04:00
daniel 73f81ffbb7 docs: archive M11 wave 1 to COMPLETED; reconcile CLAUDE.md
Batch capture + panel action buttons/labels landed; conform-on-insert
verified already shipped; resample-and-mute-source cut by Daniel
(Design View park/hide supersedes it). Drag-out remains in PLAN.
2026-07-26 19:41:23 -04:00
daniel e8300869df Merge m11-w1-t2-panel-triggers: panel action buttons + keybinding labels 2026-07-26 19:36:29 -04:00
daniel 22f91ac1d1 docs(product): split look-and-feel into Phase L (L1 kit / L2 panel / L3 VST-restyle)
Port visual-design-language.md to dev with DS-1/2/3 settled (B + spectral
strip; LICE + WDL free game; thorough M11-aware panel layout). L1 shared
kit; L2 panel redesign after M11 merges; L3 VST restyle gated on Phase S
landing. Phase S adopts the kit when it lands — not gated.
2026-07-26 19:36:00 -04:00
daniel 36bdef742a M11: action-trigger buttons + keybinding labels in bank_panel
New pure action_buttons module (strip layout/hit-test + label format,
CTest-covered). Panel strip fires capture/insert/provenance actions via
NamedCommandLookup + Main_OnCommand; labels from kbd_getTextFromCmd.
2026-07-26 19:33:04 -04:00
daniel 813c9f5cc6 docs: archive Phase R (R1-R3) to COMPLETED; reconcile CLAUDE.md + CONTEXT.md 2026-07-26 19:27:03 -04:00
daniel daa4338218 Merge m11-w1-t1-capture-polish: batch capture per item / razor area 2026-07-26 19:25:40 -04:00
daniel d23a3f9bb8 feat(capture): M11 batch capture - one bank sample per selected item / razor area
Pure batch_capture module (plan + mixed-result aggregation, unit-tested);
CAPTURE_BATCH_ITEMS/RAZOR actions with transient per-unit selection restored
on all paths, per-unit invariants + provenance, single persist.
Conform-on-insert already shipped.
2026-07-26 19:24:33 -04:00
daniel 83cd040f26 Merge Phase R (Reclaim): prune path — pure core, dry-run shell, guarded deletion 2026-07-26 19:21:15 -04:00
daniel e44bb7e2e7 Merge R3: guarded prune deletion — confirm-to-delete + panel button 2026-07-26 19:15:54 -04:00
daniel ef2d3fa846 fix(prune): honest reclaim/skip counts; cross-ref layout coupling
Already-absent files no longer inflate reclaimedCount (outAlreadyAbsent
distinguishes vanished-at-delete from real failures). Stale skip count
de-dups confirmed before subtraction so duplicates aren't tallied as
stale. prune_button.h rightInset and drawTailFooter vrc.right now
cross-reference each other by name.
2026-07-26 19:15:54 -04:00
daniel 7b53ba16f6 feat(prune): R3 guarded deletion — confirm-to-delete + panel button
Extend BANK_PRUNE_FOLDER from report-only to dry-run→confirm-with-manifest→
delete exactly the pure-core orphan set (fresh recompute, stale entries skipped).
Windows routes to Recycle Bin (SHFileOperation+FOF_ALLOWUNDO), else unlink.
New pure prune_button module + footer button dispatching the action id. No
ext-state write, no undo point (deletion is not REAPER-undoable).
2026-07-26 19:15:54 -04:00
daniel 105a4421a8 Merge R2: dry-run prune shell + persist wiring, report-only 2026-07-26 19:12:07 -04:00
daniel 1f0efe6db6 fix(persist): use non-throwing directory_iterator increment in pruneDryRun
Replace range-based for over fs::directory_iterator with manual
it.increment(ec) form. Mid-iteration failures now break to a
best-effort partial list instead of throwing filesystem_error
across REAPER's C ABI. Split shared fec into reg_ec/sz_ec.
2026-07-26 19:12:07 -04:00
daniel c1473c42e1 feat(prune): R2 dry-run prune shell + persist wiring, report-only
Add ReaSamplerSession::pruneDryRun enumerating the resolved current bank
folder, feeding the R1 core, and returning a PruneReport (count/bytes/list).
New pure bankRelativeForName + buildPruneReport keep spelling and tally
testable. Register forever-stable BANK_PRUNE_FOLDER action, report-only. No deletion.
2026-07-26 19:12:07 -04:00
daniel 46176f3f04 Merge R1: prune-reconcile pure core 2026-07-26 19:09:39 -04:00
daniel 3cfa9239d2 feat(prune): R1 prune-reconcile pure core — (owned ∩ present) − referenced
Add REAPER-free/filesystem-free prune orphan-set core + additive
BankBook::referencedPaths() union query, with full unit coverage.
2026-07-26 19:09:39 -04:00
daniel b6464f78c8 Merge gitignore-idea: ignore IDE ctest runner state 2026-07-26 18:16:42 -04:00
daniel a75174f3d5 docs: archive M10 provenance to COMPLETED; reconcile CLAUDE.md + CONTEXT.md
M10 landed. CLAUDE.md gains provenance/provenance_shell entries, test
target, and a current-state refresh; CONTEXT.md null-test line annotated
(verification action cut, manual only).
2026-07-26 18:16:36 -04:00
daniel 455012a973 gitignore: ignore .idea/ctestState.xml 2026-07-26 18:16:17 -04:00
daniel c81e125241 Merge m10-provenance: provenance + re-capture from source (bank-only) 2026-07-26 18:11:54 -04:00
daniel 7d0fcc49ac fix(m10): item-scope take-FX fingerprint; Windows path case-fold; comments
Item scope now reads the active take's FX chain via TakeFX_* (new
fxChainIdentityForItems helper), not the owning track's chain.
normalizeSlashes lowercases on _WIN32 for detectParent. Stale
comments corrected; case-fold tests added.
2026-07-26 18:08:44 -04:00
daniel 20018c1df2 M10: provenance populate + re-capture from source (bank-only)
Pure provenance core (recipe fingerprint, FX-chain identity, parent
detection) + shell reads; capture stamps provenance on resample-from-sample;
re-capture regenerates a provenanced sample from its source, never touching
the timeline. Adds BankIndex/BankBook in-place update. CTest-covered.
2026-07-26 18:08:44 -04:00
daniel 399dafa859 Merge ux: silent sample remove — undo is the safety net 2026-07-26 17:28:48 -04:00
daniel ff4eb26eab ux: drop last-reference confirm from sample remove; silent remove via undo (R-B) 2026-07-26 17:27:05 -04:00
daniel 6199a4868d Merge fix: WAV-aware content hash — identical captures now collapse despite bext timestamps 2026-07-26 17:13:26 -04:00
daniel 78fc5bad94 fix(dedup): hash WAV fmt+data only, skipping render-varying metadata chunks
hashWavContent walks RIFF chunks and feeds only fmt body + data payload
through FNV-1a ('W' domain-separation prefix), skipping bext/iXML/LIST that
REAPER embeds with per-render origination timestamps. Fallback to whole-file
hashBytes for non-WAV. Wired into both capture commit paths.

Legacy entries keep their stored whole-file hash; a re-capture will not
collapse onto a pre-fix entry -- a one-time clean capture resolves it.
2026-07-26 17:09:58 -04:00
daniel 6a6d305cf2 docs: archive Phase V (V1-V4) to COMPLETED; reconcile CLAUDE.md
Phase V landed: app_version module, ext-state version stamp, show-version
action, beta-in-isolation channel build. CLAUDE.md gains the module entry,
version key, test target, and beta-build note.
2026-07-26 16:56:04 -04:00
daniel 88e10c18c7 Merge fix: populate contentHash at capture — last-reference confirm now accurate; dedup-by-hash live 2026-07-26 16:46:29 -04:00
daniel eb5195edd4 Merge phase-v-versioning: Phase V versioning + beta-in-isolation channel 2026-07-26 16:46:06 -04:00
daniel b950926969 chore: ignore /build-beta/ directory 2026-07-26 16:43:23 -04:00
daniel 5c0e3a8ccf feat(version): V4 beta-in-isolation channel via -DREASAMPLER_CHANNEL
Compile-time channel flag forks a fully isolated reaper_reasampler_beta
(namespace, command-id prefix, action names, dock ident, -beta render) from
one auditable app_version definition. Stable identity byte-unchanged.
2026-07-26 16:43:23 -04:00
daniel 5fabade90c fix(capture): populate contentHash on captured samples to fix always-prompting remove
contentHash was left empty on every capture; hashReferencedElsewhere returns
false for empty hashes, so every remove looked like a last reference. Add
FNV-1a hashBytes to capture_paths, wire into both commit paths. NOTE: this
activates index dedup-by-hash in production — a bit-identical re-capture now
collapses onto the existing entry instead of adding a duplicate (spec-intended).
2026-07-26 16:37:46 -04:00
daniel 0a9d8200c7 fix(cmake): remove duplicate app_version.cpp from module sources
src/app_version.cpp was listed in the reaper_reasampler target_sources
block and also compiled into the app_version static lib that the module
links. One compile via the lib is correct; the duplicate TU in the module
was an ODR/duplicate-symbol hazard on ld.
2026-07-26 16:37:27 -04:00
daniel f6dddbf5a3 feat(version): single-source semver, ext-state stamp, show-version action
Version "0.9.01" sourced once from CMake via configure_file'd header; pure
app_version module (parse/compare/classify) with CTest. Stamp rides the persist
save seam under "reasampler"/"version"; absent stamp reads as pre-versioning.
On-demand "show version" action, no startup print.
2026-07-26 16:35:10 -04:00
daniel 791a9c60eb Merge fixes: UI mojibake (ASCII strings) + whole banks-grid drop zone 2026-07-26 16:15:53 -04:00
daniel 5d1f0336a9 fix(bank_panel): make entire named-banks grid a valid drop target 2026-07-26 16:14:34 -04:00
daniel 7cd1a2588e fix: replace multi-byte UTF-8 in runtime UI strings with ASCII to fix Windows-1252 mojibake 2026-07-26 16:09:13 -04:00
daniel c66f44ba1f docs: archive Phase B (B1-B5, B-cap, R-B) to COMPLETED; reconcile CLAUDE.md 2026-07-26 15:51:13 -04:00
daniel 5a3e6df4c3 Merge Phase B completion: B5 sample-remove, B-cap owned-file manifest, R-B batched undo + reload hook 2026-07-26 15:41:52 -04:00
daniel 8c0ce427e8 Merge dev into phase-b-multibank (m11 console cleanup + Phase S/V docs) before dev promotion
# Conflicts:
#	src/actions.cpp
#	src/main.cpp
2026-07-26 15:41:25 -04:00
daniel 79ed66c4d8 Merge panel-undo pass: panel gestures get R-B undo points 2026-07-26 15:33:34 -04:00
daniel 704a7b5ffc chore(bank_panel): clean up persistBook dead code and stale comment; align transfer switch to explicit enum cases 2026-07-26 15:32:22 -04:00
daniel 3514bb0b6d route bank_panel bank-op persists through persistBankOp so panel gestures get undo points like the bindable actions 2026-07-26 15:25:15 -04:00
daniel 3f3ee94e77 Merge B5: sample-remove verb — this-bank scope, confirm-on-last-reference 2026-07-26 15:14:37 -04:00
daniel 6c1efa0f25 B5: sample-remove verb — index-only drop, this-bank scope, confirm-on-last-reference 2026-07-26 15:07:41 -04:00
daniel 22f07d0654 Merge B-cap: owned-file manifest seam — capture records created files 2026-07-26 14:53:49 -04:00
daniel 363baa108c Merge m11-debug-cleanup: remove routine console chatter 2026-07-26 14:51:35 -04:00
daniel 63f35fa58d feat(persist): owned-file manifest seam — capture records created files (B-cap)
Pure OwnedFileManifest (relative paths, dedup, JSON round-trip) persisted
under sibling owned_files ext-state key; both capture commit paths record;
joins the R-B undo-reload set. Phase R prune consumes it later.
2026-07-26 14:50:18 -04:00