Commit Graph

957 Commits

Author SHA1 Message Date
daniel 0976ea13a8 Resolve ReaSampler 9000 samples against the instance's own project, not the focused tab
sampleRoots matches getReaperParent(3) among EnumProjects' open projects; every instrument sample read goes through an ordered root list (one root today) so a later temp-bank root slots in after it.
2026-09-25 14:55:50 -04:00
daniel c3e7556261 Docs: record cross-rate playback; finish SEPT_VERIFY sample-rate checks 2026-09-25 14:31:27 -04:00
daniel 783ad7546e Merge cross-rate playback: ReaSampler 9000 plays any file rate at its own pitch and length 2026-09-25 14:29:55 -04:00
daniel 30bc5a9e77 Tidy reasampler_processor.h ceiling, restamp contour publish, tighten pitch-shift test bound
Splits BuiltCapture/sourceRateRefusalText into processor_snapshot.h; fixes stale lock-nesting notes; restamp now also publishes liveContours_ like reload; tightens a slack test bound and one drifted comment.
2026-09-25 14:29:43 -04:00
daniel 648fa515ad Merge dev into ux-w1-t1-sample-rate: take the spline live-drag and plugin-drop work 2026-09-25 14:17:20 -04:00
daniel 64f314a6a4 Fix cross-rate Preserve splices, re-stamp on host-rate change, name the rate refusal
The splice crossfade now counts output frames and stops before the ring's far end (this also fixes a lap at matched rate). The search strides by the rate ratio. The editor takes its time base from its own decode. Same-rate output is pinned to hashes from before the change.
2026-09-25 14:17:11 -04:00
daniel d22def7c13 Docs: record plugin-editor drop; update SEPT_VERIFY plugin-drop checks 2026-09-25 14:16:59 -04:00
daniel 9347c861a7 Merge plugin-editor drop: a card dragged onto a third-party plugin's editor is handed to the OS as a file drop 2026-09-25 14:15:47 -04:00
daniel 7e523b0505 Clean up stale editor-hInstance comments, add isOwnModulePath edge tests
Drops a false claim about ReaSampler's own editor's hInstance, corrects the real reason for registering the wndproc class against our own module, and covers isOwnModulePath's separator edge cases.
2026-09-25 14:15:36 -04:00
daniel faa513cafb Fix SWELL drag guard, channel-fork the VST editor window class, dedupe own-module match
Panel drag no longer misfires on SWELL's always-zero wParam; stable/beta VST editors register distinct window classes against their own module instead of colliding on REAPER's; own-module basename matching moves to a tested pure helper.
2026-09-25 14:11:22 -04:00
daniel 599d525e06 Docs: record live spline-envelope drags; file two follow-ups in TODO.md 2026-09-25 14:04:35 -04:00
daniel 3ecbdb26e2 Merge live spline-envelope drags: held and new notes follow a dragged knot 2026-09-25 14:02:23 -04:00
daniel 4567744b8f Fix spline-drag rollback, bake contour leak, held-note live miss, amp clamp
Editor close mid-drag now rolls back published contours like capture-loss does; bake detaches liveContours so a printed capture can't observe a live drag; a held note now receives a live publish that lands in the same block as a note-on; amp spline read clamped to [0,1].
2026-09-25 13:59:37 -04:00
daniel fee941a83d Exempt ReaSampler 9000's own editor from the plugin OS drag hand-off
A dragged bank card over our own instrument's editor was OLE-dropping like a third-party plugin. Classify our channel's own .vst3 module as Instrument, not Plugin, so it keeps the normal instrument-drop outcome.
2026-09-25 13:57:11 -04:00
daniel 0484599408 Fix stuck drag after OS hand-off withdrawal, split panel_drag_os, doc fixes
Re-checks the physical button before resuming an internal drag and treats a button-up move mid-drag as a release, closing a stale-payload/silent-drop bug; splits the OS hand-off seam into its own TU for the line ceiling; corrects two docs and skips a redundant module-path lookup.
2026-09-25 13:52:28 -04:00
daniel 550a0a86e4 Docs: record Phase Omega's landed work in COMPLETED.md, trim it from PLAN.md 2026-09-25 13:46:10 -04:00
daniel 5151cb41dc Docs: add SEPT_VERIFY.md, the DAW checklist for Aug-Sept work 2026-09-25 13:45:33 -04:00
daniel ec60cf78c6 Play cross-rate captures at their own pitch and length
The voice now converts the file's rate to the host's at note-on instead of assuming they match. Stage times resolve at the host rate, the filter solves at it, and the bake follows. Same-rate renders are unchanged bit for bit.
2026-09-25 13:44:39 -04:00
daniel f7505d0e53 Make spline EG drags audible live: held and new notes follow a dragged knot
Contours ride their own seqlock block into a double-buffered engine copy, and the swap step is smoothed. Each drag move publishes contours without a model write; release still commits and reloads.
2026-09-25 13:42:25 -04:00
daniel fe1aec5925 Hand a card dragged onto a plugin's own editor to the OS as a file drop; withdraw the OLE drag when the pointer returns to REAPER
A code-ownership proof (window class procedure's module, via the pure window_origin) plus REAPER's FX-surface token routes a plugin editor to OLE; FX chrome keeps the instrument drop. The OLE loop re-asks the law each turn, so passing a plugin editor stays reversible.
2026-09-25 13:39:39 -04:00
daniel 0a77b0071d Docs: list PLAN.md and VERIFICATION.md in CLAUDE.md, correct TODO-1.0.md's role 2026-09-25 13:37:06 -04:00
daniel 9ff34b0a9e Docs: record the FX-drain indicator in COMPLETED.md 2026-08-21 16:03:15 -04:00
daniel 67dfa540ee Merge the indicator polish pass: sign-off note lifted, overclaim corrected, duplicated rationale trimmed 2026-08-21 16:01:03 -04:00
daniel 3fa4d10b91 Lift the sign-off DRAFT note, fix footer/cursor CLAUDE.md overclaim, honest-en the readout-width test, trim duplicated rationale
Removed DRAFT marker on approved readout strings; corrected "paint and cursor cannot disagree" to note drag-cue suppression; renamed the width test to state it only bounds character count, not pixels; trimmed restated rationale to its CLAUDE.md/header home.
2026-08-21 15:59:32 -04:00
daniel ae305b6788 Merge the FX-drain busy indicator: a busy cursor and a direction-naming footer readout over fxReclaimActivity 2026-08-21 15:45:19 -04:00
daniel bbdeba9dda Guard the FX-drain busy indicator against silent enum drift and cursor edge cases
Promote drainStateNow's switch to error-on-missing-case locally; set DWLP_MSGRESULT on WM_SETCURSOR; add an HTCLIENT guard; skip refreshBusyCursor during a live drag; mark the docked-dialog WM_SETCURSOR routing premise [verify - DAW].
2026-08-21 15:14:55 -04:00
daniel fbb87316bf Docs: correct two stale line-count figures in the 600-line-ceiling TODO entry 2026-08-21 14:52:48 -04:00
daniel 4acde051b1 Docs: record the Design View mode-switch redesign in COMPLETED.md 2026-08-21 14:50:22 -04:00
daniel 052fbb0d52 Make the background FX drain visible: a busy cursor over the panel and a footer readout that names its direction, driven off fxReclaimActivity 2026-08-21 14:45:25 -04:00
daniel da8401239a Merge the Design View redesign: pure-layer park split, shell restructure, the FX reclaimer, and one undo point per mode switch 2026-08-21 14:14:56 -04:00
daniel 580a41b5ba Merge the undo-span work: one Ctrl-Z per Design View mode switch, and a single undo-block opener for the tree 2026-08-09 14:08:22 -04:00
daniel 258b1b6b85 Remove the temporary undo-span tracing now that the mid-drain Ctrl-Z fix has landed
Deletes the ring-buffer tracer and its diagnostic action; reverts the span
entry points to their pre-tracing no-parameter signatures.
2026-08-09 13:53:56 -04:00
daniel f6f09d983c Close the FX reclaim span when REAPER's own Undo/Redo is dispatched, so the switch's point mints first
Both command hooks intercept Edit: Undo (40029) and Edit: Redo (40030) and consume
nothing. Undo routes that never dispatch an action remain uncovered.
2026-08-09 13:40:28 -04:00
daniel e423bf6502 Buffer undo trace to a ring, add dump action, stop per-tick loadSaveProj spam
Trace lines fill a 4096-line ring instead of hitting the console per line;
DUMP_UNDO_TRACE drains it in one ShowConsoleMsg call. Overflow is marked, not silent.
2026-08-09 13:16:05 -04:00
daniel b782fb2731 Add temporary undo-span tracing for the mid-drain Ctrl-Z bug
One switch (REASAMPLER_UNDO_TRACE) gates every line. Traces span open/close
reasons, FX writes, UndoBlock depth, timer standoffs, and load-state hooks.
2026-08-09 12:28:50 -04:00
daniel d5ff476a19 Make Design View membership edits undoable: the view_state write moves inside the block
All four actions share one body; the point turns on a model diff, so a no-op
leaves history and the Undo button alone. The Save-As prompt stays outside.
2026-08-07 19:51:37 -04:00
daniel 20fef2a3bf Keep the extension's tick out of REAPER's own project load, and re-earn the park holds across one load 2026-08-07 18:03:58 -04:00
daniel 3d95eb715c Undo-block review fixes: exception-safe depth, corrected docs, real test teeth
Fixes ctor exception safety, a ValidatePtr2 guard, false SDK-citation and
enforcement claims, the span-depth invariant, and vacuous fx_reclaim tests.
2026-08-07 17:07:56 -04:00
daniel b7b93a7ac3 One undo-block opener for the whole tree: fourteen sites route through it, and the reclaim span can no longer swallow a user's act
The drain refuses a tick inside a foreign block; applyMode wakes the reclaimer
before it opens the span.
2026-08-07 16:38:11 -04:00
daniel b2f6b3f1d0 Design View: no undo block may open over the reclaim span, and a reapply closes none
Every opener ends the span first, so a tag fired mid-drain no longer hijacks the
switch's point. One stated criterion governs both lane sites; no-op actions discard.
2026-08-07 15:13:52 -04:00
daniel 39529a5ac4 Design View: drop the undo blocks around writes that mint nothing; the membership actions own theirs
Flag writes are silent from a timer, so a block around a reapply or the reconcile
repair could only manufacture a point. The real switch's span is unchanged.
2026-08-07 14:41:17 -04:00
daniel 67d9ec3da9 Put the FX reclaimer to sleep on a project-state load instead of waking it
abandon() clears the wakeup where invalidate() raises it, so File > Revert
cannot converge FX or spend park records against a model nothing re-read.
2026-08-07 14:23:56 -04:00
daniel 39b995e824 Terminate the FX reclaimer's undo span on EVERY project-state load, not just undo
BeginLoadProjectState now routes unbranched through fxReclaimAbandonForStateLoad;
only the session's deferred reload stays undo-only.
2026-08-07 13:57:06 -04:00
daniel 9b6f725747 Close the FX reclaimer's undo span at the state-load hook, and expose the drain's direction
A Ctrl-Z mid-span used to close the pre-undo block over post-undo state; it now
terminates at BeginLoadProjectState and stops the drain where it stands.
fxReclaimActivity reports Online/Offline/Idle; fxReclaimPending is unchanged.
2026-08-07 13:45:58 -04:00
daniel 86aa8dabba Collapse a Design View mode switch and its background FX parking to ONE undo point
applyMode now returns with its undo block open; the reclaimer closes it when the drain
settles. A transport deferral or a tab switch ends it early -- two points, never a leak.
2026-08-07 12:53:42 -04:00
daniel 2173263bb9 Docs: reflect the Design View redesign — EXPOSE replaces the park refusal, FX offlining moved to the reclaimer, undo repair is ours 2026-08-06 23:56:50 -04:00
daniel c9c957a3da Merge Wave 3: the FX reclaimer (per-track atomic drain, generation-owned queue, transport-gated offline, save-time release flush) 2026-08-06 23:35:27 -04:00
daniel 4f6cf60740 Narrow the FX reclaimer's transport gate to defer offline work only; let online drain through, and always run the park clock's observe 2026-08-06 23:04:02 -04:00
daniel c95203718a fx_reclaim: use GetCurrentProjectInLoadSave for the save hook, stop disarming ReleaseFlush on one write, validate project before cached-track lookup 2026-08-06 22:52:57 -04:00
daniel 02790f1270 Gate the FX reclaimer on the transport, both directions; move the release's persist off the drain and onto the project save
The drain no longer dirties a project on its own initiative — a spent park record rides the user's next save via OnSaveExtensionConfig.
2026-08-06 22:31:47 -04:00