daniel
faa513cafb
Fix SWELL drag guard, channel-fork the VST editor window class, dedupe own-module match
...
Panel drag no longer misfires on SWELL's always-zero wParam; stable/beta VST editors register distinct window classes against their own module instead of colliding on REAPER's; own-module basename matching moves to a tested pure helper.
2026-09-25 14:11:22 -04:00
daniel
0484599408
Fix stuck drag after OS hand-off withdrawal, split panel_drag_os, doc fixes
...
Re-checks the physical button before resuming an internal drag and treats a button-up move mid-drag as a release, closing a stale-payload/silent-drop bug; splits the OS hand-off seam into its own TU for the line ceiling; corrects two docs and skips a redundant module-path lookup.
2026-09-25 13:52:28 -04:00
daniel
fe1aec5925
Hand a card dragged onto a plugin's own editor to the OS as a file drop; withdraw the OLE drag when the pointer returns to REAPER
...
A code-ownership proof (window class procedure's module, via the pure window_origin) plus REAPER's FX-surface token routes a plugin editor to OLE; FX chrome keeps the instrument drop. The OLE loop re-asks the law each turn, so passing a plugin editor stays reversible.
2026-09-25 13:39:39 -04:00
daniel
67524206fb
2nd Pass Render
2026-08-05 16:21:17 -04:00
daniel
0e6a0d3618
fix: use crosshair cursor for arrange-drop cue instead of I-beam
...
The I-beam read as a text-editing cursor rather than a timeline placement point.
2026-08-03 17:49:18 -04:00
daniel
a5febbd6aa
Merge drag-out hand-off fix: keep the drag internal while the pointer is over REAPER
2026-08-03 16:45:14 -04:00
daniel
b71a05fbef
Close the bridged-process hole in the drag-out hand-off gate
...
OsHandoff now needs the window-ownership proof AND a hit-test that named
nothing, so a bridged plugin's UI can't read as off-REAPER.
2026-08-03 16:42:59 -04:00
daniel
9599e96e0c
Fix drag-out giving live drags to OLE: prove the pointer left REAPER
...
OffReaper leaves the surface vocabulary; OsHandoff now gates on a window-ownership
proof resolved in the shell, so no in-REAPER surface can reach DoDragDrop.
2026-08-03 15:50:25 -04:00
daniel
32c7e959ae
Extract elapsedAtLeast to core/util, dedupe the throttle rationale, and correct the alloc-count/PLAN citations
2026-08-03 14:58:33 -04:00
daniel
9d10f151da
Ψ-W1-T4 remediation: gate silent arrange drops, pin surface totality, hedge unverified SDK claims, close comment/exception-safety minors
2026-08-01 20:13:17 -04:00
daniel
fe3ac79ab5
Ψ-W1-T4: resolve drop targets per move, not once — every surface gets a defined outcome, a cue, and no silent no-op
2026-08-01 19:43:37 -04:00
daniel
c91bf03ef4
Fix drag-drop review findings: unify teardown, gate FX-add on outside-panel, trim comments
2026-07-30 06:56:20 -04:00
daniel
875d5b4632
Fix drag-handoff bugs: gate FX re-resolve on outside-panel, cache unresolvable OS-drag verdict, block double FX-add retry
2026-07-30 00:09:00 -04:00
daniel
0800760833
Fix drag-out losing audio and FX-container drops losing the capture; re-home ingest under shell/actions
2026-07-29 23:49:53 -04:00
daniel
cc36dd59c7
Cut shell/panel comment bloat ~47% (comments only, zero code change)
2026-07-29 20:48:56 -04:00
daniel
f3be4d8cce
Q-W6: registration table (OCP) in main.cpp; bank verbs -> shell/bank_ops(Session&); persist.h + wav_trim + namespaces.h shims deleted; 61/61
...
capture.h realtime seam split to capture_realtime_shell.h; GetProjExtState grow-loop rehomed to core/wire/ext_state_read; stale persist.cpp/bank_panel.cpp comment refs fixed; CLAUDE.md persist/bank_book/actions bullets updated. Command-id suffixes, display phrases, and undo labels byte-identical.
2026-07-29 13:40:09 -04:00
daniel
430e117620
Q-W4: split actions.cpp into design_view_actions/bank_actions/prune_action + shared action_registry; bank verbs deduped into promptless bankOp* inner verbs in panel_bank_ops (one mutation home, two UX skins); command-id strings byte-identical; actions.h shim carrier retired
2026-07-29 12:56:02 -04:00
daniel
19b12186ac
Q-W2 review follow-ups: anon-namespace TU-private panel helpers, fix stale bank_panel.cpp comments, correct shim-transitivity claim
...
Wraps ~50 file-local helpers across all eight panel TUs in namespace{} (dissolves the menuAppend default-arg ODR trap); zero behavior change, 60/60 green.
2026-07-29 11:29:10 -04:00
daniel
30a4ffd01b
Q-W2: split bank_panel.cpp (3459 LOC) into eight shell/panel TUs — reasampler::panel internals, per-seam public headers, shim retired; zero behavior change, 60/60 green
2026-07-29 11:29:10 -04:00
daniel