daniel 0ab4673887 Fix eight review findings on the render-bounds diagnostics ...

Corrects a false comment example, fixes two tests that couldn't detect their
own regressions, adds two more read-back checkpoints around Main_OnCommand so
a drift report self-locates, guards a spurious zero-vs-zero coincidence match,
and softens two sentences that overclaimed cause or defect.

2026-08-02 14:45:42 -04:00

..

test_action_bar.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_app_version_padding.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_app_version.cpp

Ψ-W1-T3 review remediation: soften the double-fire claim to unspecified-by-SDK, mark the unload mirror [verify — DAW], fix stale comment, drop redundant assertions, dedupe hook-partitioning comments, drop what-comment; file the action_registry test-seam deferral.

2026-08-01 20:13:13 -04:00

test_assignment_request.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bake_hold.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_bake_plan.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_bake_render.cpp

Ξ-W2-T1 re-review cleanup: soften ordering claim, bound bake guard fields, dedup gain/play-mode rationale, quiet foreign WrongProject noise

2026-08-01 17:23:00 -04:00

test_bake_reset.cpp

Ξ-W2-T1 remediation: print master gain into the bake, derive the window from the dialed sound, reset play mode to Trigger

2026-08-01 17:05:28 -04:00

test_bake_window.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_bake_wire.cpp

Take the read-back back out of the persist; a write verdict belongs only where evidence crosses the plugin boundary

2026-08-02 13:42:51 -04:00

test_bank_book.cpp

Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

2026-07-28 21:34:09 -04:00

test_bank_grid.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bank_model.cpp

Merge Ψ-W2-T2: a bit-identical capture collapses to one lossless mono channel

2026-08-01 22:23:06 -04:00

test_bank_sync.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_batch_capture.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_bridge_marshal.cpp

Q-W6: registration table (OCP) in main.cpp; bank verbs -> shell/bank_ops(Session&); persist.h + wav_trim + namespaces.h shims deleted; 61/61

2026-07-29 13:40:09 -04:00

test_browser_scroll.cpp

Retire the zone system: one capture = one parameter set, and re-seam the engine and Sample face into bands

2026-07-30 07:15:54 -04:00

test_capture_browser.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_capture_name.cpp

Ψ-W2-T1 remediation: scrim the card name over the waveform, hedge two SDK claims, fix a UTF-8-truncation empty-label bug, file the legibility DAW deferral

2026-08-01 22:08:35 -04:00

test_capture_paths.cpp

Q-W3: main.cpp → pointers+entry+dispatch via 4 capture hoists; one pure wav_codec RIFF owner; ICaptureBackend deleted; capture_realtime rename + finalize split; shared stampCaptureSample; makeUniqueTag gains monotonic counter (fixes same-second batch collisions). 60/60 green.

2026-07-29 11:33:28 -04:00

test_capture_realtime.cpp

Q-W3: main.cpp → pointers+entry+dispatch via 4 capture hoists; one pure wav_codec RIFF owner; ICaptureBackend deleted; capture_realtime rename + finalize split; shared stampCaptureSample; makeUniqueTag gains monotonic counter (fixes same-second batch collisions). 60/60 green.

2026-07-29 11:33:28 -04:00

test_card_drag.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_card_meta.cpp

Name captures after their source track: label and filename both, on every interactive mint site, and show the name on the panel card

2026-08-01 21:46:53 -04:00

test_component_geometry.cpp

test: tighten waveform-collapse and knob-face rect assertions

2026-08-01 10:07:47 -04:00

test_component_state_io.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_curve_law.cpp

instrument: fix AHD DecayEnd overlay/grab defect, pin flaky curve test, close comment/doc findings

2026-07-31 10:19:45 -04:00

test_curve_popup.cpp

fix: close review findings on the velocity-curve deck and bipolar curves

2026-07-31 19:46:37 -04:00

test_deck_groups.cpp

feat: legible ReaSampler 9000 editor — bigger knobs, ms time constants, per-ring double-click reset, and an antialiased draw pass

2026-08-01 09:16:30 -04:00

test_deck_values.cpp

fix: restore waveform symmetry about the midline, cut deck_values' link to the bank model, and unit-test the column arithmetic

2026-08-01 09:47:07 -04:00

test_drag_out.cpp

Ψ-W1-T4 remediation: gate silent arrange drops, pin surface totality, hedge unverified SDK claims, close comment/exception-safety minors

2026-08-01 20:13:17 -04:00

test_embed_strip.cpp

Retire the zone system: one capture = one parameter set, and re-seam the engine and Sample face into bands

2026-07-30 07:15:54 -04:00

test_envelope_edit.cpp

instrument: fix AHD DecayEnd overlay/grab defect, pin flaky curve test, close comment/doc findings

2026-07-31 10:19:45 -04:00

test_envelope_overlay.cpp

instrument: fix AHD DecayEnd overlay/grab defect, pin flaky curve test, close comment/doc findings

2026-07-31 10:19:45 -04:00

test_file_bytes.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_filter_morph.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_filter_params.cpp

Add an Oberheim-SEM morph law to the SVF filter: HP->notch->LP alongside HP->BP->LP, selected at prepare() time, free on the per-sample path

2026-07-30 11:04:20 -04:00

test_filter_state.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_filter.cpp

Fix filter test/doc claims: retracted DF1 limit-cycle rationale, notch-depth overreach, stale drive-branch wording

2026-07-30 11:04:20 -04:00

test_footer_bar.cpp

Ψ-W1-T2 review remediation: solo restore drops on visible-in-target, not parked; N-mode segments read dead when unroutable

2026-08-01 20:13:10 -04:00

test_guid_diff.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_insert_plan.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_instrument_drop.cpp

Ψ-W1-T4: resolve drop targets per move, not once — every surface gets a defined outcome, a cue, and no silent no-op

2026-08-01 19:43:37 -04:00

test_json.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_keyboard_strip.cpp

Clear stale hover on capture-loss and Alt-delete; derive gutter test via chromeRects

2026-07-30 11:03:41 -04:00

test_knob_deck.cpp

test: tighten waveform-collapse and knob-face rect assertions

2026-08-01 10:07:47 -04:00

test_lane_keys.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_live_delivery.cpp

instrument: the filter's velocity depth knob returns and multiplies the bipolar curve; the pre-v12 lift is a pure domain re-tag

2026-07-31 20:24:40 -04:00

test_live_params.cpp

instrument: one staged-envelope system — per-segment curves, the sustain-less AHD, and a shared overlay for all three envelopes

2026-07-31 08:37:57 -04:00

test_loop_span.cpp

loop: fix the crossfade seam's residual discontinuity, plus six review minors

2026-07-31 17:59:58 -04:00

test_master_gain.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_mode_enable.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_mode_switch.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_musical_division.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_note_program.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_origin_ledger.cpp

fix: classify future-version ledgers with changed record shape correctly, not as corrupt

2026-07-30 20:25:46 -04:00

test_overflow_menu.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_param_slider.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_peaks.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_pitch_shift.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_provenance.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_prune_button.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_prune_reconcile.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_render_settings.cpp

capture: state the bounds tolerance as empirical, refuse unmeasurable renders, keep refused ones for diagnosis

2026-08-02 07:23:30 -04:00

test_render_window.cpp

Fix eight review findings on the render-bounds diagnostics

2026-08-02 14:45:42 -04:00

test_resample_name.cpp

Ξ-W2-T1: the resample bake chain — instrument renders, extension banks, one click re-points and resets

2026-08-01 16:26:28 -04:00

test_sample_bands.cpp

Type-enforce the waveform overlay contract, narrow waveformLanes to LaneSplit, fix laneCount/cache/path-fallback bugs

2026-07-30 09:35:11 -04:00

test_sample_chrome.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_sample_map.cpp

instrument: the filter's velocity depth knob returns and multiplies the bipolar curve; the pre-v12 lift is a pure domain re-tag

2026-07-31 20:24:40 -04:00

test_sample_usage.cpp

tracking: one ledger, one authority — prune protection and replace-vs-add answered from the same records, fail-safe on unreadable state

2026-07-30 19:44:11 -04:00

test_sampler_core.cpp

Close derived-bake-window review findings: NaN-guard remaining wire doubles, pin Trigger-span agreement, retire dead quantizer

2026-08-01 21:32:05 -04:00

test_sampler_filter.cpp

instrument: the filter's velocity depth knob returns and multiplies the bipolar curve; the pre-v12 lift is a pure domain re-tag

2026-07-31 20:24:40 -04:00

test_slot_map.cpp

Q-W1 code-review follow-ups: restore 104 trailing newlines, relocate reasampler_uid.h to core/wire, drop ext_keys namespaces shim, add slot_map_tests, golden serialize literals for 4 modules, namespaces.h/pragma-once ordering sweep. 60/60 green.

2026-07-28 21:34:09 -04:00

test_solo_cache.cpp

Ψ-W1-T2 review remediation: solo restore drops on visible-in-target, not parked; N-mode segments read dead when unroutable

2026-08-01 20:13:10 -04:00

test_spline_edit.cpp

fix: pin the waveform arbitration in a testable predicate, close round-4 review minors

2026-08-01 00:17:06 -04:00

test_spline_egs.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_staged_envelopes.cpp

instrument: fix AHD node-tracking/tie-break/live-latch defects and close staged-envelope-curve test gaps

2026-07-31 09:52:17 -04:00

test_stroke_aa.cpp

fix: enlarge every sub-2px stroker width to 2px, per Daniel's ruling

2026-08-01 15:11:58 -04:00

test_tab_strip.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_tail_control.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_tempo.cpp

note: close every value type's domain at construction, so resolveNote is finite for every constructible input

2026-07-30 20:37:12 -04:00

test_theme.cpp

Ψ-W2-T1 remediation: scrim the card name over the waveform, hedge two SDK claims, fix a UTF-8-truncation empty-label bug, file the legibility DAW deferral

2026-08-01 22:08:35 -04:00

test_tooltip.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_track_topology.cpp

Ψ-W1-T1 second-round remediation: ±1-frame bounds tolerance, self-cleanup a refused render, hedge two unverified render-source inferences

2026-08-01 21:18:03 -04:00

test_tracking_authority.cpp

Ξ-W2-T1: the resample bake chain — instrument renders, extension banks, one click re-points and resets

2026-08-01 16:26:28 -04:00

test_trigger_seam.cpp

Bake window: derived note lengths carry exact durations, not ladder rungs — a long take is no longer cut at 384 beats

2026-08-01 21:10:38 -04:00

test_velocity_curve.cpp

fix: close Θ-W7-T1 review — scaling guard, opacity claims, two vacuous test fixes

2026-08-01 13:45:43 -04:00

test_view_mode_model.cpp

Ψ-W1-T2: disjoint per-mode solo surfaces and a playback-gated mode switch

2026-08-01 19:43:18 -04:00

test_view_tree.cpp

Q-W1 pt2: core/shell/app relocation + sub-namespaces; one concrete ui::Rect (LTRB fork retired); slot_map split from bank_book; BankIndex→BankModel; 59/59 green

2026-07-28 21:34:09 -04:00

test_wav_codec.cpp

Ψ-W3 remediation: fix the verify doc's wrong render source, add missing content checks, soften unverified claims

2026-08-01 23:01:50 -04:00

test_waveform_view.cpp

fix: pin the waveform arbitration in a testable predicate, close round-4 review minors

2026-08-01 00:17:06 -04:00

test_wire.cpp

Q-W2v: split VST god-modules — editor 8 face-axis TUs (+pure layout hoist), processor 3 TUs, component_state_io codec split (extension drops the voice engine), zone_params.h, core/wire putLE; formats frozen, 61/61 green

2026-07-29 11:29:36 -04:00