daniel
57a137199e
Move completed M1 (bank_model core) from PLAN.md to COMPLETED.md; record the parseInt int64-to-int narrowing as a future-hardening note.
56 lines
3.1 KiB
Markdown
56 lines
3.1 KiB
Markdown
# COMPLETED.md — ReaSampler landed milestones
|
|
|
|
Completed milestone entries removed from `PLAN.md`. Each entry preserves its
|
|
original Goal, Verify, and checklist points with boxes marked done.
|
|
|
|
---
|
|
|
|
## Milestone 0 — Transition scaffold: reaper_mpeview → ReaSampler
|
|
**Goal:** Retire the MPE scaffold and stand up the sampler's pure core in its
|
|
place, preserving the pure-core / REAPER-shell split.
|
|
**Verify:** `cmake -B build -S .` configures clean; `cmake --build build` builds
|
|
the renamed extension target and the pure-core test target; `ctest --test-dir
|
|
build` is green with the new `bank_model` + `peaks` suites present.
|
|
|
|
- [x] Delete `src/mpe_model.{h,cpp}` and `src/mpe_view.{h,cpp}`; remove
|
|
`tests/test_mpe_model.cpp`.
|
|
- [x] Rename the CMake `project()` and the extension MODULE target from
|
|
`reaper_mpeview` to `reaper_reasampler` (binary `OUTPUT_NAME` likewise);
|
|
update `PREFIX ""` / platform SUFFIX blocks to the new target name.
|
|
- [x] Replace the pure `mpe_model` static lib + `mpe_model_tests` executable with
|
|
`bank_model` (pure static lib) + `bank_model_tests`; keep the CTest wiring.
|
|
- [x] Repoint `src/main.cpp`: drop the `mpe_view.h` include and all `MpeView_*`
|
|
calls (toggle / IsOpen / OnTimer / Cleanup); stub the extension entry so it
|
|
loads, logs to console, and registers nothing MPE-specific. The
|
|
`command_id` / `gaccel` / `hookcommand` registration *pattern* is preserved for
|
|
reuse (CLAUDE.md §REAPER extension contract) — the MPE action string is removed.
|
|
- [x] Choose and record the persistent action-id prefix for the sampler family
|
|
(replaces `CEREBELLUM_MPEVIEW_TOGGLE`); this string is forever-stable once
|
|
shipped (CLAUDE.md §action registration).
|
|
- [x] Refresh `README.md` layout/next-step sections to the sampler module set.
|
|
(Landed-work reflection is doc-keeper's; this point exists so the stale MPE
|
|
README does not mislead the first implementer.)
|
|
|
|
---
|
|
|
|
## Milestone 1 — bank_model + JSON round-trip (pure)
|
|
**Goal:** The `Sample` metadata struct and `BankIndex` (add / remove / query /
|
|
tier moves / dedup-by-hash) with JSON serialize/deserialize to `std::string`.
|
|
CONTEXT.md §Data model, §Module architecture.
|
|
**Verify:** CTest green. Round-trip is lossless (deserialize(serialize(x)) == x)
|
|
across all fields; dedup-by-hash and tier filtering asserted; **relative paths
|
|
only** invariant enforced at the model boundary (no absolute path accepted/stored).
|
|
|
|
- [x] Define `Sample` with the full field set (id, display name, relative path,
|
|
source mode, source range in project time + PPQ, track GUID(s), wet/dry,
|
|
channels, SR, length sec + beats, capture tempo, optional key, peak/RMS/LUFS,
|
|
clip flag, tier, content hash, provenance, created ts). CONTEXT.md §Data model.
|
|
- [x] `BankIndex`: ordered collection keyed by id; add / remove / query.
|
|
- [x] Hash lookup for dedup-by-content-hash.
|
|
- [x] Tier model (scratch | archive) + tier-move + tier filtering; scratch marked
|
|
auto-prunable.
|
|
- [x] JSON serialize/deserialize to/from `std::string`.
|
|
- [x] Tests: full-field round-trip lossless; dedup collapses equal-hash adds;
|
|
tier filter/move correct; relative-path invariant rejects absolute paths;
|
|
empty-index and malformed-JSON edge cases.
|